Linux Kernel Mentees list
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Adi Nata <adinata.softwareengineer@gmail.com>
Cc: joshua.crofts1@gmail.com, dlechner@baylibre.com,
	nuno.sa@analog.com, andy@kernel.org,
	u.kleine-koenig@baylibre.com, email@sirat.me,
	mazziesaccount@gmail.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH v2] iio: chemical: ccs811: cleanup checkpatch __packed warning
Date: Sun, 2 Aug 2026 17:48:57 +0100	[thread overview]
Message-ID: <20260802174857.3118d263@jic23-huawei> (raw)
In-Reply-To: <20260802022559.23138-1-adinata.softwareengineer@gmail.com>

On Sun,  2 Aug 2026 10:25:56 +0800
Adi Nata <adinata.softwareengineer@gmail.com> wrote:

> Change instance of __attribute__((__packed__)) to __packed per
> checkpatch.pl warning.
> 
> Reported by checkpatch:
> FILE: drivers/iio/chemical/ccs811.c
> 
> WARNING: Prefer __packed over __attribute__((__packed__))
> +} __attribute__((__packed__));
> 
> Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
> 
> v2:

This needs to be below the ---

Also please do not send a new version of a series in reply to
an earlier one.  

1. Leads to very confusing threads if there is much discussion.
2. Means your patch is way back in any reviewers inbox as sorting
   is typically be date of first mail in thread.


Thanks,

Jonathan


> - Rename commit message to include driver name
> 
> ---
>  drivers/iio/chemical/ccs811.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/chemical/ccs811.c b/drivers/iio/chemical/ccs811.c
> index ce7187ccd706..0e5c79b775a2 100644
> --- a/drivers/iio/chemical/ccs811.c
> +++ b/drivers/iio/chemical/ccs811.c
> @@ -70,7 +70,7 @@ struct ccs811_reading {
>  	u8 status;
>  	u8 error;
>  	__be16 raw_data;
> -} __attribute__((__packed__));
> +} __packed;
>  
>  struct ccs811_data {
>  	struct i2c_client *client;


      parent reply	other threads:[~2026-08-02 16:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 16:10 [PATCH] iio: chemical: cleanup codestyle warning Adi Nata
2026-07-23 21:51 ` Joshua Crofts
2026-07-23 21:53   ` Joshua Crofts
2026-08-02  2:25     ` [PATCH v2] iio: chemical: ccs811: cleanup checkpatch __packed warning Adi Nata
2026-08-02 15:14       ` David Lechner
2026-08-02 16:48       ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260802174857.3118d263@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=adinata.softwareengineer@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=email@sirat.me \
    --cc=joshua.crofts1@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox