From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8247F125D5 for ; Tue, 20 Aug 2024 19:47:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.136 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724183261; cv=none; b=HgDDu0NR87Q8Jg6mamZQzGavmOh/UnmoLNA9fwmoRWBPWmo2z1WOkH5eqRVrSognyg/1bmghTwFCLLPyCpTiGRfMk2OspDlSIGLclZAxYaCnLAblhRmyhboS79/aplw2IF7H6gP2ii82J3paXHEwCn375n2zlFNRzh2N0Kwt8+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724183261; c=relaxed/simple; bh=i0CsVAVNg6mFCh0+dev4hO4WQyvGoe/wPJjjY5VtOk4=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=iSpQT+Ybvupgm/0C3JsNIqBp2SJX5MyLKjR63gBJA0z1vWHfmGdTuUlvr9IK7uV/xn5tGqF0V8TVLSn9nIrICaeUs8cjW+tkJb8jG5H5qtOURp41ZrjUjAMneIScIvRIlj11KTFYtghW6YhzKF8lBlfpN0qxX4+ZivZ3VM1R2MA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wanadoo.fr header.i=@wanadoo.fr header.b=bI+NW17y; arc=none smtp.client-ip=140.211.166.136 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wanadoo.fr header.i=@wanadoo.fr header.b="bI+NW17y" Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 25AE360765 for ; Tue, 20 Aug 2024 19:47:39 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org X-Spam-Flag: NO X-Spam-Score: -5.794 X-Spam-Level: Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id AJvZJiWNJs4L for ; Tue, 20 Aug 2024 19:47:38 +0000 (UTC) X-Greylist: delayed 551 seconds by postgrey-1.37 at util1.osuosl.org; Tue, 20 Aug 2024 19:47:37 UTC DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 03AD86072D Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=wanadoo.fr DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 03AD86072D Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=wanadoo.fr header.i=@wanadoo.fr header.a=rsa-sha256 header.s=t20230301 header.b=bI+NW17y Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=80.12.242.74; helo=msa.smtpout.orange.fr; envelope-from=christophe.jaillet@wanadoo.fr; receiver= Received: from msa.smtpout.orange.fr (smtp-74.smtpout.orange.fr [80.12.242.74]) by smtp3.osuosl.org (Postfix) with ESMTPS id 03AD86072D for ; Tue, 20 Aug 2024 19:47:37 +0000 (UTC) Received: from [192.168.1.37] ([90.11.132.44]) by smtp.orange.fr with ESMTPA id gUgQsMRgMyTq2gUgQs5xkP; Tue, 20 Aug 2024 21:38:24 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1724182704; bh=NlO7mLF+NT33sRpCRl6DO3FkKqiceX8jbHbbMHO1dVk=; h=Message-ID:Date:MIME-Version:From:Subject:To; b=bI+NW17yUjQTIlOmVgdhuGiGsxyDADnPI4CkQaxmJlPyZPijVpOBcR2wtR1BYKO6x GkYgvcYhwowQ4XgPlw+x/pZME81XyOU+LBy6ai7kqsIO/+OuhmhW5rSNf/6kkj1EiX hOoaeIrZ6sR7r5NVnFyb+xMzvsCE3DvPpn3itzieZxoINMARcuBJD5Htb4HJOJfPJf TNg3cGhsTemICqAkkbAqSg54e7UoRJ2Gr2imPebcfR3vKRpnPNm/mWi9J651rRWxpt oY+GBk6JJRqbKnx2p/0AbvfLyKvdo46OJJ3GqsyX3frXsv59ULQRyDBPujQt8bQtiT hUa0obIJ8UmEw== X-ME-Helo: [192.168.1.37] X-ME-Auth: bWFyaW9uLmphaWxsZXRAd2FuYWRvby5mcg== X-ME-Date: Tue, 20 Aug 2024 21:38:24 +0200 X-ME-IP: 90.11.132.44 Message-ID: <2348e646-e1da-4deb-ab55-c438a42e25b3@wanadoo.fr> Date: Tue, 20 Aug 2024 21:38:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel-mentees@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Christophe JAILLET Subject: Re: [PATCH] staging: rtl8192e: Replace strcpy with strscpy in rtl819x_translate_scan To: Abhishek Tamboli , gregkh@linuxfoundation.org Cc: tdavies@darkphysics.net, philipp.g.hortmann@gmail.com, garyrookard@fastmail.org, linux-staging@lists.linux.dev, skhan@linuxfoundation.org, rbmarliere@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org References: <20240820184216.45390-1-abhishektamboli9@gmail.com> Content-Language: en-US, fr-FR In-Reply-To: <20240820184216.45390-1-abhishektamboli9@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 20/08/2024 à 20:42, Abhishek Tamboli a écrit : > Replace strcpy() with strscpy() in rtl819x_translate_scan() > function to ensure buffer safety. > > Signed-off-by: Abhishek Tamboli > --- > drivers/staging/rtl8192e/rtllib_wx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c > index fbd4ec824084..970b7fcb3f7e 100644 > --- a/drivers/staging/rtl8192e/rtllib_wx.c > +++ b/drivers/staging/rtl8192e/rtllib_wx.c > @@ -61,7 +61,7 @@ static inline char *rtl819x_translate_scan(struct rtllib_device *ieee, > iwe.cmd = SIOCGIWNAME; > for (i = 0; i < ARRAY_SIZE(rtllib_modes); i++) { > if (network->mode & BIT(i)) { > - strcpy(pname, rtllib_modes[i]); > + strscpy(pname, rtllib_modes[i], sizeof(pname)); This not correct. sizeof(pname) is 4 here, but the buffer that is really used is "char proto_name[6];" 6 chars are needed for storing "N-24G" (see rtllib_modes), so 5 chars + ending \0. When you will send a v2, here are a few others things you could give a look at: - is 'pname' really needed or is 'proto_name' enough? - what about the "*pname = '\0';" after the loop? - if a "mode" matches, do we need to iterate the whole rtllib_modes array? (have a look at wireless_mode) CJ > pname += strlen(rtllib_modes[i]); > } > } > -- > 2.34.1 > > >