From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Remington Brasga <rbrasga@uci.edu>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] kselftest: missing arg in ptrace.c
Date: Mon, 15 Jul 2024 08:20:02 +0530 [thread overview]
Message-ID: <321d4481-256c-41d9-9f64-f7e04e8d21be@arm.com> (raw)
In-Reply-To: <20240712231730.2794-1-rbrasga@uci.edu>
On 7/13/24 04:47, Remington Brasga wrote:
> The string passed to ksft_test_result_skip is missing the `type_name`
>
> Signed-off-by: Remington Brasga <rbrasga@uci.edu>
> ---
> clang-tidy reported clang-diagnostic-format-insufficient-args warning
> on this line, so I am fixing it.
>
> tools/testing/selftests/arm64/abi/ptrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
> index abe4d58d731d..6144f83f8ab4 100644
> --- a/tools/testing/selftests/arm64/abi/ptrace.c
> +++ b/tools/testing/selftests/arm64/abi/ptrace.c
> @@ -156,7 +156,7 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
> /* Zero is not currently architecturally valid */
> ksft_test_result(arch, "%s_arch_set\n", type_name);
> } else {
> - ksft_test_result_skip("%s_arch_set\n");
> + ksft_test_result_skip("%s_arch_set\n", type_name);
> }
> }
>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
next prev parent reply other threads:[~2024-07-15 2:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 23:17 [PATCH] kselftest: missing arg in ptrace.c Remington Brasga
2024-07-15 2:50 ` Anshuman Khandual [this message]
2024-07-15 12:02 ` Dev Jain
2024-07-16 4:19 ` Dev Jain
2024-07-18 15:34 ` Will Deacon
2024-07-23 14:26 ` Will Deacon
2024-07-23 15:46 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=321d4481-256c-41d9-9f64-f7e04e8d21be@arm.com \
--to=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rbrasga@uci.edu \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox