From: Shuah Khan <skhan@linuxfoundation.org>
To: Abdelrahman Fekry <abdelrahmanfekry375@gmail.com>, shauh@Kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: size: fix grammar and align output formatting
Date: Thu, 22 May 2025 15:27:33 -0600 [thread overview]
Message-ID: <3a73cef3-83f0-4e26-b8ff-3c289a7cd52f@linuxfoundation.org> (raw)
In-Reply-To: <20250513214438.300430-1-Abdelrahmanfekry375@gmail.com>
On 5/13/25 15:44, Abdelrahman Fekry wrote:
> Improve the grammar in the test name by changing "get runtime memory use"
> to "get runtime memory usage". Also adjust spacing in output lines
> ("Total:", "Free:", etc.) to ensure consistent alignment and readability.
>
> Signed-off-by: Abdelrahman Fekry <AbdelrahmanFekry375@gmail.com>
Did you run checkpatch on this patch? I am seeing
CHECK: From:/Signed-off-by: email comments mismatch: 'From: Abdelrahman Fekry <abdelrahmanfekry375@gmail.com>' != 'Signed-off-by: Abdelrahman Fekry <Abdelrahmanfekry375@gmail.com>'
Please fix it and send v2.
thanks,
-- Shuah
next prev parent reply other threads:[~2025-05-22 21:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 21:44 [PATCH] selftests: size: fix grammar and align output formatting Abdelrahman Fekry
2025-05-22 21:27 ` Shuah Khan [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-05-13 21:46 Abdelrahman Fekry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a73cef3-83f0-4e26-b8ff-3c289a7cd52f@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=abdelrahmanfekry375@gmail.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shauh@Kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox