Re: [PATCH] scsi: Use kmalloc_array to prevent overflow of dynamic size calculation

[Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>]

On 06/10/25 16:58, Niklas Cassel wrote:
> On Sat, Oct 04, 2025 at 09:55:22AM +0530, Bhanu Seshu Kumar Valluri wrote:
>> On 03/10/25 20:23, James Bottomley wrote:
>>> On Wed, 2025-10-01 at 17:09 +0530, Bhanu Seshu Kumar Valluri wrote:
>>>> Use kmalloc_array to avoid potential overflow during dynamic size
>>>> calculation inside kmalloc.
>>>
>>> This description isn't correct.
>>>
>>> Given this check
>>>
>>>>  
>>>> -	host_memory_descriptor->host_chunk_virt_address =
>>>> kmalloc(sg_count * sizeof(void *), GFP_KERNEL);
>>>
>>> How is it possible that this allocation could ever overflow?
>>>
>>> If you want to change the description to say using kmalloc_array is
>>> better practice or something (and the maintainer concurs) that's fine,
>>> but we can't have a false justification in the kernel git log.
>>>
>>> Regards,
>>>
>>> James
>>>
>> Hi,
>>
>> Thank you for your helpful comment. 
>> I will await till maintainer confirms if it is ok to push this change as v2 with
>> subject line similar what you have suggested.
> 
> You misinterpreted James' reply ("and the maintainer concurs").
> 
> James is one of the two SCSI maintainers, so there is no need to
> delay sending a V2.

Hi Niklas,

Thanks for clarifying  that. I will send v2 patch.

Regards,
Bhanu Seshu Kumar Valluri