From: Jacob Keller <jacob.e.keller@intel.com>
To: I Viswanath <viswanathiyyappan@gmail.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<horms@kernel.org>, <sdf@fomichev.me>, <kuniyu@google.com>,
<ahmed.zaki@intel.com>, <aleksander.lobakin@intel.com>,
<andrew+netdev@lunn.ch>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<skhan@linuxfoundation.org>,
<linux-kernel-mentees@lists.linux.dev>,
<david.hunter.linux@gmail.com>, <khalid@kernel.org>
Subject: Re: [RFC net-next PATCH 0/2] net: Split ndo_set_rx_mode into snapshot and deferred write
Date: Wed, 22 Oct 2025 16:46:00 -0700 [thread overview]
Message-ID: <417c677f-268a-4163-b07e-deea8f9b9b40@intel.com> (raw)
In-Reply-To: <20251020134857.5820-1-viswanathiyyappan@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 601 bytes --]
On 10/20/2025 6:48 AM, I Viswanath wrote:
> 3. All calls to modify rx_mode should pass through the set_rx_mode +
> schedule write_rx_config execution flow.
>
> 1 and 2 are guaranteed because of the properties of work queues
>
> Drivers need to ensure 3
>
Is there any mechanism to make this guarantee either implemented or at
least verified by the core? If not that, what about some sort of way to
lint driver code and make sure its correct?
In my experience, requiring drivers to do something right typically
results in a long tail of correcting drivers into the future..
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2025-10-22 23:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 13:48 [RFC net-next PATCH 0/2] net: Split ndo_set_rx_mode into snapshot and deferred write I Viswanath
2025-10-20 13:48 ` [RFC net-next PATCH 1/2] net: Add ndo_write_rx_config and helper structs and functions I Viswanath
2025-10-20 13:48 ` [RFC net-next PATCH 2/2] net: ethernet: Implement ndo_write_rx_config callback for the 8139cp driver I Viswanath
2025-10-22 23:46 ` Jacob Keller [this message]
2025-10-24 5:31 ` [RFC net-next PATCH 0/2] net: Split ndo_set_rx_mode into snapshot and deferred write I Viswanath
2025-10-24 20:20 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=417c677f-268a-4163-b07e-deea8f9b9b40@intel.com \
--to=jacob.e.keller@intel.com \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=david.hunter.linux@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=khalid@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=skhan@linuxfoundation.org \
--cc=viswanathiyyappan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox