From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Mehdi Ben Hadj Khelifa <mehdi.benhadjkhelifa@gmail.com>
Cc: <ast@kernel.org>, <daniel@iogearbox.net>, <davem@davemloft.net>,
<kuba@kernel.org>, <hawk@kernel.org>, <john.fastabend@gmail.com>,
<sdf@fomichev.me>, <andrii@kernel.org>, <martin.lau@linux.dev>,
<eddyz87@gmail.com>, <song@kernel.org>, <yonghong.song@linux.dev>,
<kpsingh@kernel.org>, <haoluo@google.com>, <jolsa@kernel.org>,
<netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <skhan@linuxfoundation.org>,
<david.hunter.linux@gmail.com>, <khalid@kernel.org>,
<linux-kernel-mentees@lists.linuxfoundation.org>
Subject: Re: [PATCH bpf-next] bpf/cpumap.c: Remove unnecessary TODO comment
Date: Mon, 20 Oct 2025 17:41:29 +0200 [thread overview]
Message-ID: <42b9b376-897e-4984-909b-218bd1e3214a@intel.com> (raw)
In-Reply-To: <20251019165923.199247-1-mehdi.benhadjkhelifa@gmail.com>
From: Mehdi Ben Hadj Khelifa <mehdi.benhadjkhelifa@gmail.com>
Date: Sun, 19 Oct 2025 17:58:55 +0100
> After discussion with bpf maintainers[1], queue_index could
> be propagated to the remote XDP program by the xdp_md struct[2]
But it's not done automatically, so not aware users may get confused.
Instead of just removing the TODO, I believe you should leave a comment
here that the RxQ index gets lots after the frame is redirected, so if
someone really wants it, he/she should use <what the second link says>.
> which makes this todo a misguide for future effort.
>
> [1]:https://lore.kernel.org/all/87y0q23j2w.fsf@cloudflare.com/
> [2]:https://docs.ebpf.io/linux/helper-function/bpf_xdp_adjust_meta/
>
> Signed-off-by: Mehdi Ben Hadj Khelifa <mehdi.benhadjkhelifa@gmail.com>
Thanks,
Olek
next prev parent reply other threads:[~2025-10-20 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-19 16:58 [PATCH bpf-next] bpf/cpumap.c: Remove unnecessary TODO comment Mehdi Ben Hadj Khelifa
2025-10-20 15:41 ` Alexander Lobakin [this message]
2025-10-20 16:45 ` Mehdi Ben Hadj Khelifa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42b9b376-897e-4984-909b-218bd1e3214a@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=david.hunter.linux@gmail.com \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=khalid@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mehdi.benhadjkhelifa@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=skhan@linuxfoundation.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox