Linux Kernel Mentees list
 help / color / mirror / Atom feed
From: Saheed Bolarinwa <refactormyself@gmail.com>
To: skhan@linuxfoundation.org, mchehab@kernel.org
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
	linux-doc@vger.kernel.org
Subject: [Linux-kernel-mentees] Clarification on the behaviour of checkpatch.pl
Date: Mon, 20 Apr 2020 02:20:19 +0200	[thread overview]
Message-ID: <445b3e38-123e-eb72-2bbb-c40ac4ea9899@gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 1551 bytes --]

Hello,

My experience is that checkpatch.pl will not flag some warnings when I use

the '-f' flag. This especially true for .rst files. My understanding is 
that this flag

is needed to use it with a raw source file instead of a patch.

Please, I will like to confirm if this is a normal behaviour or is it my 
system setup.

Below is an example from the current stable release linux-5.6.y

    [saheed@net linux-stable]$ perl ./scripts/checkpatch.pl -f
    ./Documentation/admin-guide/hw-vuln/tsx_async_abort.rst
    total: 0 errors, 0 warnings, 279 lines checked

    ./Documentation/admin-guide/hw-vuln/tsx_async_abort.rst has no
    obvious style problems and is ready for submission.


    [saheed@net linux-stable]$ perl ./scripts/checkpatch.pl
    ./Documentation/admin-guide/hw-vuln/tsx_async_abort.rst
    WARNING: Possible unwrapped commit description (prefer a maximum 75
    chars per line)
    #6:
    TAA is a hardware vulnerability that allows unprivileged speculative
    access to

    ERROR: Does not appear to be a unified-diff format patch

    total: 1 errors, 1 warnings, 0 lines checked

    NOTE: For some of the reported defects, checkpatch may be able to
           mechanically convert to the typical style using --fix or
    --fix-inplace.

    ./Documentation/admin-guide/hw-vuln/tsx_async_abort.rst has style
    problems, please review.

    NOTE: If any of the errors are false positives, please report
           them to the maintainer, see CHECKPATCH in MAINTAINERS.


    Thank you.

    Bolarinwa Saheed


[-- Attachment #1.2: Type: text/html, Size: 2096 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

             reply	other threads:[~2020-04-20  1:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20  0:20 Saheed Bolarinwa [this message]
2020-04-20  6:56 ` [Linux-kernel-mentees] Clarification on the behaviour of checkpatch.pl Mauro Carvalho Chehab
2020-04-21  8:44   ` Saheed Bolarinwa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=445b3e38-123e-eb72-2bbb-c40ac4ea9899@gmail.com \
    --to=refactormyself@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=mchehab@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox