Re: [PATCH v2] drm/amd/display: adds kernel-doc comment for dc_stream_remove_writeback()

Alex Hung
2025-05-05T16:03:03Z

Reviewed-by: Alex Hung <alex.hung@amd.com>

On 5/3/25 15:18, James Flowers wrote:
> Adds kernel-doc for externally linked dc_stream_remove_writeback function.
>
> Signed-off-by: James Flowers <bold.zone2373@fastmail.com>
> ---
> V1 -> V2: Corrected checkpatch warnings and errors
>
> drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> index e6e41678525f..b883fb24fa12 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> @@ -569,6 +569,14 @@ bool dc_stream_fc_disable_writeback(struct dc *dc,
> return true;
> }
>
> +/**
> + * dc_stream_remove_writeback() - Disables writeback and removes writeback info.
> + * @dc: Display core control structure.
> + * @stream: Display core stream state.
> + * @dwb_pipe_inst: Display writeback pipe.
> + *
> + * Return: returns true on success, false otherwise.
> + */
> bool dc_stream_remove_writeback(struct dc *dc,
> struct dc_stream_state *stream,
> uint32_t dwb_pipe_inst)