From: Bart Van Assche <bvanassche@acm.org>
To: Rujra Bhatt <braker.noob.kernel@gmail.com>,
Kai.Makisara@kolumbus.fi, James.Bottomley@hansenpartnership.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH] scsi:st.c replace snprintf() with sysfs_emit()
Date: Thu, 24 Jul 2025 08:24:47 -0700 [thread overview]
Message-ID: <45edee98-b720-4641-a1e8-77b1a96bb340@acm.org> (raw)
In-Reply-To: <CAG+54DbmHbw4MWUSF3x1qQC4bF7Uuu8mDD7aAZyBtbJ1D51MUw@mail.gmail.com>
On 7/23/25 5:58 PM, Rujra Bhatt wrote:
> replace snprintf() with sysfs_emit() or sysfs_emit_at() in st.c file to
> follow kernel's guidelines from Documentation/filesystems/sysfs.rst
> This improves safety, consistency and easier to maintain and update it
> in the future.
sysfs_emit() is for new code only. There is no requirement to convert
existing code to sysfs_emit() / sysfs_emit_at().
Bart.
next prev parent reply other threads:[~2025-07-24 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 0:58 [PATCH] scsi:st.c replace snprintf() with sysfs_emit() Rujra Bhatt
2025-07-24 15:24 ` Bart Van Assche [this message]
2025-07-25 14:22 ` "Kai Mäkisara (Kolumbus)"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45edee98-b720-4641-a1e8-77b1a96bb340@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=Kai.Makisara@kolumbus.fi \
--cc=braker.noob.kernel@gmail.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox