From: Paolo Abeni <pabeni@redhat.com>
To: Deepak Sharma <deepak.sharma.472935@gmail.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
horms@kernel.org, pwn9uin@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev,
david.hunter.linux@gmail.com, skhan@linuxfoundation.org,
syzbot+740e04c2a93467a0f8c8@syzkaller.appspotmail.com,
syzbot+07b635b9c111c566af8b@syzkaller.appspotmail.com
Subject: Re: [PATCH net v2] atm: Fix the cleanup on alloc_mpc failure in atm_mpoa_mpoad_attach
Date: Tue, 30 Sep 2025 10:45:24 +0200 [thread overview]
Message-ID: <54234daf-ace1-4369-baea-eab94fcea74b@redhat.com> (raw)
In-Reply-To: <20250925204251.232473-1-deepak.sharma.472935@gmail.com>
On 9/25/25 10:42 PM, Deepak Sharma wrote:
> diff --git a/net/atm/mpc.c b/net/atm/mpc.c
> index f6b447bba329..4f67ad1d6bef 100644
> --- a/net/atm/mpc.c
> +++ b/net/atm/mpc.c
> @@ -804,7 +804,7 @@ static int atm_mpoa_mpoad_attach(struct atm_vcc *vcc, int arg)
> /* This lets us now how our LECs are doing */
> err = register_netdevice_notifier(&mpoa_notifier);
> if (err < 0) {
> - timer_delete(&mpc_timer);
> + timer_delete_sync(&mpc_timer);
AFAICS the mpc_timer can rearm itself, so this the above is not enough
and you should use timer_shutdown_sync() instead.
Thanks,
Paolo
next prev parent reply other threads:[~2025-09-30 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 20:42 [PATCH net v2] atm: Fix the cleanup on alloc_mpc failure in atm_mpoa_mpoad_attach Deepak Sharma
2025-09-26 14:28 ` Simon Horman
2025-09-30 8:45 ` Paolo Abeni [this message]
2025-09-30 13:33 ` Deepak Sharma
2025-09-30 14:31 ` Paolo Abeni
2025-09-30 15:13 ` Cortex Auth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54234daf-ace1-4369-baea-eab94fcea74b@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=david.hunter.linux@gmail.com \
--cc=deepak.sharma.472935@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pwn9uin@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+07b635b9c111c566af8b@syzkaller.appspotmail.com \
--cc=syzbot+740e04c2a93467a0f8c8@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox