From: Ankan Biswas <spyjetfayed@gmail.com>
To: Lasse Collin <lasse.collin@tukaani.org>
Cc: skhan@linuxfoundation.org, khalid@kernel.org,
david.hunter.linux@gmail.com, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev,
Phillip Lougher <phillip@squashfs.org.uk>
Subject: Re: [PATCH] lib/xz: remove dead IA-64 (Itanium) support code
Date: Mon, 13 Oct 2025 23:06:31 +0530 [thread overview]
Message-ID: <56075d23-8bae-4a11-b5a5-9ed251fc7707@gmail.com> (raw)
In-Reply-To: <20251013183800.7af293f5.lasse.collin@tukaani.org>
On 10/13/25 9:08 PM, Lasse Collin wrote:
> On 2025-10-13 Ankan Biswas wrote:
>> Support for the IA-64 (Itanium) architecture was removed in
>> commit cf8e8658100d ("arch: Remove Itanium (IA-64) architecture").
>>
>> This patch drops the IA-64 specific decompression code from
>> lib/xz, which was conditionally compiled with the now-obsolete
>> CONFIG_XZ_DEC_IA64 option.
>
> The commit cf8e8658100d ("arch: Remove Itanium (IA-64) architecture")
> unconditionally disabled the IA-64 filter, which effectively dropped
> support for mounting Squashfs file systems that use XZ with the IA-64
> filter. I wasn't Cc'ed when it was committed because I wasn't in
> MAINTAINERS back then. If I had been, I might have commented that the
> commits [1] and [2] and the discussion [3] showed that keeping filters
> available for non-native archs can be desirable. But now that time has
> passed and no one has complained about the lack of IA-64 filter, it
> seems fine to remove it completely from Linux.
>
> I won't remove the IA-64 filter from the upstream version of
> xz_dec_bcj.c, so this change will make those files diverge a little
> more. That's unfortunate, but they already differ by a tiny amount
> anyway.
>
> xz_private.h line 106 checks if XZ_DEC_IA64 is defined. That line
> should be removed too. With that change:
>
> Acked-by: Lasse Collin <lasse.collin@tukaani.org>
>
> [1] 5dc49c75a26b ("decompressors: make the default XZ_DEC_* config
> match the selected architecture")
> [2] bf4d064d89ae ("lib/xz: enable all filters by default in Kconfig")
> [3] https://lore.kernel.org/lkml/20140228230017.GE14970@merlin.infradead.org/T/
>
Hi Lasse,
I have sent a v2 of the patch with the required changes.
Sorry about having to make your work a little more difficult.
And thanks for retaining support in the upstream for IA-64.
Regards,
Ankan Biswas
prev parent reply other threads:[~2025-10-13 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251013115136.16773-1-spyjetfayed@gmail.com>
2025-10-13 13:09 ` [PATCH] lib/xz: remove dead IA-64 (Itanium) support code Ankan Biswas
2025-10-13 15:38 ` Lasse Collin
2025-10-13 17:36 ` Ankan Biswas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56075d23-8bae-4a11-b5a5-9ed251fc7707@gmail.com \
--to=spyjetfayed@gmail.com \
--cc=david.hunter.linux@gmail.com \
--cc=khalid@kernel.org \
--cc=lasse.collin@tukaani.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@squashfs.org.uk \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox