* Re: [PATCH] lib/xz: remove dead IA-64 (Itanium) support code
[not found] <20251013115136.16773-1-spyjetfayed@gmail.com>
@ 2025-10-13 13:09 ` Ankan Biswas
2025-10-13 15:38 ` Lasse Collin
0 siblings, 1 reply; 3+ messages in thread
From: Ankan Biswas @ 2025-10-13 13:09 UTC (permalink / raw)
To: lasse.collin
Cc: skhan, khalid, david.hunter.linux, linux-kernel,
linux-kernel-mentees
Hey all,
Correcting the mailing-list again, from linux-kernel-mentees@kernel.org
to linux-kernel-mentees@lists.linux.dev.
Really sorry about this.
Thanks,
Ankan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lib/xz: remove dead IA-64 (Itanium) support code
2025-10-13 13:09 ` [PATCH] lib/xz: remove dead IA-64 (Itanium) support code Ankan Biswas
@ 2025-10-13 15:38 ` Lasse Collin
2025-10-13 17:36 ` Ankan Biswas
0 siblings, 1 reply; 3+ messages in thread
From: Lasse Collin @ 2025-10-13 15:38 UTC (permalink / raw)
To: Ankan Biswas
Cc: skhan, khalid, david.hunter.linux, linux-kernel,
linux-kernel-mentees, Phillip Lougher
On 2025-10-13 Ankan Biswas wrote:
> Support for the IA-64 (Itanium) architecture was removed in
> commit cf8e8658100d ("arch: Remove Itanium (IA-64) architecture").
>
> This patch drops the IA-64 specific decompression code from
> lib/xz, which was conditionally compiled with the now-obsolete
> CONFIG_XZ_DEC_IA64 option.
The commit cf8e8658100d ("arch: Remove Itanium (IA-64) architecture")
unconditionally disabled the IA-64 filter, which effectively dropped
support for mounting Squashfs file systems that use XZ with the IA-64
filter. I wasn't Cc'ed when it was committed because I wasn't in
MAINTAINERS back then. If I had been, I might have commented that the
commits [1] and [2] and the discussion [3] showed that keeping filters
available for non-native archs can be desirable. But now that time has
passed and no one has complained about the lack of IA-64 filter, it
seems fine to remove it completely from Linux.
I won't remove the IA-64 filter from the upstream version of
xz_dec_bcj.c, so this change will make those files diverge a little
more. That's unfortunate, but they already differ by a tiny amount
anyway.
xz_private.h line 106 checks if XZ_DEC_IA64 is defined. That line
should be removed too. With that change:
Acked-by: Lasse Collin <lasse.collin@tukaani.org>
[1] 5dc49c75a26b ("decompressors: make the default XZ_DEC_* config
match the selected architecture")
[2] bf4d064d89ae ("lib/xz: enable all filters by default in Kconfig")
[3] https://lore.kernel.org/lkml/20140228230017.GE14970@merlin.infradead.org/T/
--
Lasse Collin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lib/xz: remove dead IA-64 (Itanium) support code
2025-10-13 15:38 ` Lasse Collin
@ 2025-10-13 17:36 ` Ankan Biswas
0 siblings, 0 replies; 3+ messages in thread
From: Ankan Biswas @ 2025-10-13 17:36 UTC (permalink / raw)
To: Lasse Collin
Cc: skhan, khalid, david.hunter.linux, linux-kernel,
linux-kernel-mentees, Phillip Lougher
On 10/13/25 9:08 PM, Lasse Collin wrote:
> On 2025-10-13 Ankan Biswas wrote:
>> Support for the IA-64 (Itanium) architecture was removed in
>> commit cf8e8658100d ("arch: Remove Itanium (IA-64) architecture").
>>
>> This patch drops the IA-64 specific decompression code from
>> lib/xz, which was conditionally compiled with the now-obsolete
>> CONFIG_XZ_DEC_IA64 option.
>
> The commit cf8e8658100d ("arch: Remove Itanium (IA-64) architecture")
> unconditionally disabled the IA-64 filter, which effectively dropped
> support for mounting Squashfs file systems that use XZ with the IA-64
> filter. I wasn't Cc'ed when it was committed because I wasn't in
> MAINTAINERS back then. If I had been, I might have commented that the
> commits [1] and [2] and the discussion [3] showed that keeping filters
> available for non-native archs can be desirable. But now that time has
> passed and no one has complained about the lack of IA-64 filter, it
> seems fine to remove it completely from Linux.
>
> I won't remove the IA-64 filter from the upstream version of
> xz_dec_bcj.c, so this change will make those files diverge a little
> more. That's unfortunate, but they already differ by a tiny amount
> anyway.
>
> xz_private.h line 106 checks if XZ_DEC_IA64 is defined. That line
> should be removed too. With that change:
>
> Acked-by: Lasse Collin <lasse.collin@tukaani.org>
>
> [1] 5dc49c75a26b ("decompressors: make the default XZ_DEC_* config
> match the selected architecture")
> [2] bf4d064d89ae ("lib/xz: enable all filters by default in Kconfig")
> [3] https://lore.kernel.org/lkml/20140228230017.GE14970@merlin.infradead.org/T/
>
Hi Lasse,
I have sent a v2 of the patch with the required changes.
Sorry about having to make your work a little more difficult.
And thanks for retaining support in the upstream for IA-64.
Regards,
Ankan Biswas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-13 17:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20251013115136.16773-1-spyjetfayed@gmail.com>
2025-10-13 13:09 ` [PATCH] lib/xz: remove dead IA-64 (Itanium) support code Ankan Biswas
2025-10-13 15:38 ` Lasse Collin
2025-10-13 17:36 ` Ankan Biswas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox