From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8A003A1691 for ; Tue, 24 Mar 2026 17:41:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774374106; cv=none; b=NxWWL0m2phyG6q9zZgFPK1di8YZ1a1dDa7PVSCYjGFvvpo2m0mjN3kIbzp1Uc5pVEkBbnlMMRxm994opugeKgShoF/a52mNVswlBXcjbh4x9ri1Vc5Oe6hVuOnc4Ma93kz62Oxw/WCatBn9UyZykC2g59pld59uQABOT0og8cwE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774374106; c=relaxed/simple; bh=5wqAQ0bTJmsAKt8oyR53qxfzZ+5Wdt4sMMgNx4PqjDk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cvriFSzXzlop7LE7UUcx7GFGZ1lqoTj6AJ4ATZCHPaP4tSAosCXqxEd8GaKRJl884c77Hy0FZgsat6xSY6z3IMEvVqvt04GTit9Ahja0VEyt4IgbT6s2HFWVVJIWTk5gaD5xGJm7hqIsRlM7VrYFjNBWwaCGoG0S/iDJ2aYz0MU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=J45t0b+R; arc=none smtp.client-ip=209.85.167.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="J45t0b+R" Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-46702742c99so1019535b6e.3 for ; Tue, 24 Mar 2026 10:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1774374103; x=1774978903; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SZS7sCjvuHhpivHZjRZo+N6jfKc3vOgopKpbJzsd0MA=; b=J45t0b+R9iV1xYpV3fnTwfv2e1mWvk9INb9I/Ql95THqCyZScqYHySNvKxQzdX50ou FOcGKCRZkpdFYMV/fUvAcacaKQ9S/25gMwE8YXsbeb4iY46o0X6LfS4q94WobiyicPw3 UeDqKZwnM01kN15kdWNBrj+J/P/KpvVE3DYwM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774374103; x=1774978903; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SZS7sCjvuHhpivHZjRZo+N6jfKc3vOgopKpbJzsd0MA=; b=QXkNofD1qtr5Ogr1pv17NwkCcgtxs81VDZB1sY6nAvGAll285M1RLp+MXxTVC4CAU4 IZ8LXEGBslzxP8YpldsPgwdm6fZWbfrPwftXYUMpdR4zTapJD4dDYyFD8osnBhzWoHF+ hPY+K0lylM5f1hLFhvt4wVE0KW3kRLBefk2EdvyY8hIFuA17dqIeeJIj1GZhv5fYLE9F 1g+DAqr6JSzlF3cQ9n/9I7rFcWTZnnFfMLiNmzzybJaP99UttUJU7o1fObtOUdY0p5CC typftDBEA7LzRYwXYWJa3ciqC61Z9TalP/5BtgcKEEUmS0S+fgQP4m6FSgIoLJheydDC zElw== X-Forwarded-Encrypted: i=1; AJvYcCW5g3H4S79orL1vlXfG8rm8Yo8cO/kbVXQZFRkKQRsex0eeuFarKTdQAnLleXdumDNvwT47UkpYV8Z+SvIcdZSaSeVUaA==@lists.linux.dev X-Gm-Message-State: AOJu0YyJg1AsRtv/TbYJAiQK/ManegEcOIKbw6FbyAzPmnDwnvgX9ARk Zz7qRFsq/K6G7N/yOgNw4dcliAshYXXsdubzV3NBw+2QKJvKOxfeii6I6pHLXC+/Zdo= X-Gm-Gg: ATEYQzy8upgrCuC1rhy+P0asb4hXiSuf0jb8p0VeqXPVO9x1NJhMwLHja0bu/pfc9dL xlQe4aQSuo36b18ApQUWUhRchph8ecjbjHl72TZa6N7wbtkVUs3KbklAeHKrvMXHPUMunMjEM6H TH2u3GGGNJ608akYbOwTSVxHNeyrWiUxlVIvKomj6/QUPGn+YiXP7TRV+I9y0iz68P6KLahuryG wPoAAciIoiUPH4LYMWa9U10ilHXxm81DhBCwvw+xySs4gt6znqWrglsVdxRWP0kuKVUU8HZ+ftp uvsTXvavfef8jO7hOCL7axironmTLtpOtLA324PP0Skmd1ToEwwxLksobThyoSGhtS0KQG8kwv0 Nl+i1uK+umuxmGZY4LMea6d+ZXScN1goG9Ab92e3TCTIYlFQTop5Ha8NUpYLwVVJ97gKtKFbi7M T9fDMkOU0egOHQ3A9W5YqJnReB8vMsp7xA2yQ= X-Received: by 2002:a05:6808:1b1e:b0:45c:8f03:1e19 with SMTP id 5614622812f47-46a5c7bfdddmr220230b6e.55.1774374103477; Tue, 24 Mar 2026 10:41:43 -0700 (PDT) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 5614622812f47-467e7d18ad3sm9498867b6e.1.2026.03.24.10.41.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 10:41:43 -0700 (PDT) Message-ID: <656d3bf5-8d97-454e-9691-540cdb79dab4@linuxfoundation.org> Date: Tue, 24 Mar 2026 11:41:40 -0600 Precedence: bulk X-Mailing-List: linux-kernel-mentees@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] staging: rtl8723bs: fix constant on left side of test checkpatch warnings To: Prithvi , Andy Shevchenko Cc: gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com, straube.linux@gmail.com, b9788213@gmail.com, ethantidmore06@gmail.com, dan.carpenter@linaro.org, weibu@redadmin.org, knavaneeth786@gmail.com, ignacio.pena87@gmail.com, dharanitharan725@gmail.com, lukagejak5@gmail.com, samasth.norway.ananda@oracle.com, karanja99erick@gmail.com, s9430939@naver.com, suunj1331@gmail.com, ysinghcin@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, david.hunter.linux@gmail.com, khalid@kernel.org, Shuah Khan References: <20260323162901.121947-1-activprithvi@gmail.com> <20260324130234.3776tp4ykuerffcg@inspiron> <20260324135551.grth7jfjyoh5krzr@inspiron> <20260324160229.f46h25ebd2mxcfiq@inspiron> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260324160229.f46h25ebd2mxcfiq@inspiron> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/24/26 10:02, Prithvi wrote: > On Tue, Mar 24, 2026 at 04:05:51PM +0200, Andy Shevchenko wrote: >> On Tue, Mar 24, 2026 at 07:25:51PM +0530, Prithvi wrote: >>> Sure. Also can you please guide if any testing would be required for these >>> changes, or I can directly send the v3 patch? >> >> It's implied that the author of the patch each time before submission (either >> a new version of the existing patch or a new patch in general) is tested and >> validated it. +1 >> >> -- >> With Best Regards, >> Andy Shevchenko >> >> > > Understood. I agree that patch must be tested and validated every time. > > To be transparent, I do not have access to the physical Realtek hardware, > so I am unable to perform runtime testing. However, for this v3, I have > performed compile testing and ensured that the module builds correctly. > Will this be acceptable for this patch? No - Hmm. Aren't you part of Fall mentorship program? We discussed this several times during the program that when someone sends a patch, it is implied that they tested the patch. Compile testing isn't sufficient. The changes in this patch not trivial spelling fixes in comments either. - if (1 <= channel && channel <= 14) { + if (channel >= 1 && channel <= 14) { I picked just one and there are more like this one. These aren't just moving the constant lies to the right side of the test, they change logic and in some cases removing the code and the change log doesn't say anything about that. Did you look into if this conditional can just go away? - if (0x00 == PathAOK) { - } I am not the maintainer for this, but as your mentor this isn't acceptable. I wouldn't take this patch unless these changes are tested on the device. thanks, -- Shuah