Linux Kernel Mentees list
 help / color / mirror / Atom feed
From: "Ayush" <ayush@disroot.org>
To: "Lukas Bulwahn" <lukas.bulwahn@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] Regarding "Linux Kernel: Evaluate and Improve checkpatch.pl"
Date: Wed, 09 Sep 2020 09:14:07 +0000	[thread overview]
Message-ID: <65d03f2a884a92f5094dc417d0bf47e0@disroot.org> (raw)
In-Reply-To: <CAKXUXMxBxyQ9KM1d92d0vGuaGRLe6+aVHa3s_O=E-YTq_jLPJA@mail.gmail.com>

> No, that is allowed. There can be of course a line break after commit
> and before the hash, it is just that the current checkpatch.pl script
> does not handle this case yet.
> 
> That would need improvement.

I have already sent a patch for handling quotes in commit messages.
(https://lists.linuxfoundation.org/pipermail/linux-kernel-mentees/2020-September/004026.html)

I have created another patch which fixes line breaks after commit and
before hash.

It can handles cases like:

- commit
1234567890ab ("foo bar")

- commit
1234567890ab ("Revert "foo bar"")

But, my question is, should I send this as a new patch or append it with
my last patch and make a patch v2?
My last patch is still under review.

> I do not think that it is disallowed, but maybe a new check in
> checkpatch.pl is recommended to make aware that quotes in commit
> message subject lines cannot be properly handled and are discouraged.

So, should we give a warning if (no. of quotes > 4)?


Regards,
Ayush
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply	other threads:[~2020-09-09  9:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200810125354.xeijyh3v5upatrez@salamander>
2020-08-17  9:43 ` [Linux-kernel-mentees] Regarding "Linux Kernel: Evaluate and Improve checkpatch.pl" Lukas Bulwahn
2020-08-21 16:18   ` Ayush
2020-08-22  8:06     ` Lukas Bulwahn
2020-08-24 10:06       ` Ayush
2020-08-26 13:51         ` Ayush
2020-08-27  5:28         ` Lukas Bulwahn
2020-08-30 18:51           ` Ayush
2020-08-31  5:14             ` Lukas Bulwahn
2020-09-06  9:59               ` Ayush
2020-09-07  7:38                 ` Lukas Bulwahn
2020-09-07 14:27                   ` Ayush
2020-09-07 16:43                     ` Lukas Bulwahn
2020-09-09  9:14                       ` Ayush [this message]
2020-09-09  9:52                         ` Lukas Bulwahn
2020-09-09 16:01                           ` Ayush
2020-09-10  6:04                             ` Lukas Bulwahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65d03f2a884a92f5094dc417d0bf47e0@disroot.org \
    --to=ayush@disroot.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=lukas.bulwahn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox