From: Bart Van Assche <bvanassche@acm.org>
To: Prithvi <activprithvi@gmail.com>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
hch@lst.de, jlbec@evilplan.org, linux-fsdevel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org,
david.hunter.linux@gmail.com, khalid@kernel.org,
syzbot+f6e8174215573a84b797@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH] scsi: target: Fix recursive locking in __configfs_open_file()
Date: Wed, 21 Jan 2026 09:59:49 -0800 [thread overview]
Message-ID: <6927d0f7-5bf5-4035-b1c2-50f3edae4b7f@acm.org> (raw)
In-Reply-To: <20260121175136.2ku57xskhwwg7syz@inspiron>
On 1/21/26 9:51 AM, Prithvi wrote:
> I tried using lockdep_register_key() and lockdep_unregister_key() for the
> frag_sem lock, however it stil gives the possible recursive locking
> warning. Here is the patch and the bug report from its test:
>
> https://lore.kernel.org/all/6767d8ea.050a0220.226966.0021.GAE@google.com/T/#m3203ceddf3423b7116ba9225d182771608f93a6f
>
> Would using down_read_nested() and subclasses be a better option here?
>
> I also checked out some documentation regarding it and learnt that to use
> the _nested() form, the hierarchy among the locks should be mapped
> accurately; however, IIUC, there isn't any hierarchy between the locks in
> this case, is this right?
>
> Apologies if I am missing something obvious here, and thanks for your
> time and guidance.
This is unexpected. Please ask help from someone who is familiar with
VFS internals. I'm not familiar with these internals.
Thanks,
Bart.
next prev parent reply other threads:[~2026-01-21 17:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 19:15 [PATCH] scsi: target: Fix recursive locking in __configfs_open_file() Prithvi Tambewagh
2026-01-15 3:20 ` Prithvi
2026-01-22 9:56 ` Dmitry Bogdanov
2026-01-22 14:29 ` Prithvi
2026-01-23 14:58 ` Prithvi
2026-01-15 16:57 ` Bart Van Assche
2026-01-19 18:50 ` Prithvi
2026-01-20 13:48 ` Bart Van Assche
2026-01-21 13:40 ` Prithvi
2026-01-21 17:51 ` Prithvi
2026-01-21 17:59 ` Bart Van Assche [this message]
2026-01-21 18:08 ` Prithvi
2026-01-21 18:29 ` Prithvi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6927d0f7-5bf5-4035-b1c2-50f3edae4b7f@acm.org \
--to=bvanassche@acm.org \
--cc=activprithvi@gmail.com \
--cc=david.hunter.linux@gmail.com \
--cc=hch@lst.de \
--cc=jlbec@evilplan.org \
--cc=khalid@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+f6e8174215573a84b797@syzkaller.appspotmail.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox