public inbox for linux-kernel-mentees@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Sravan Kumar Gundu <sravankumarlpu@gmail.com>, daniel@ffwll.ch
Cc: skhan@linuxfoundation.com, linux-fbdev@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	syzbot+c4b7aa0513823e2ea880@syzkaller.appspotmail.com
Subject: Re: [PATCH] fbdev: Fix vmalloc out-of-bounds write in fast_imageblit
Date: Sat, 2 Aug 2025 21:30:39 +0200	[thread overview]
Message-ID: <69c344cd-acf4-4363-b4a5-d07226fff609@gmx.de> (raw)
In-Reply-To: <20250731203618.25973-1-sravankumarlpu@gmail.com>

On 7/31/25 22:36, Sravan Kumar Gundu wrote:
> This issue triggers when a userspace program does an ioctl
> FBIOPUT_CON2FBMAP by passing console number and frame buffer number.
> Ideally this maps console to frame buffer and updates the screen if
> console is visible.
> 
> As part of mapping it has to do resize of console according to frame
> buffer info. if this resize fails and returns from vc_do_resize() and
> continues further. At this point console and new frame buffer are mapped
> and sets display vars. Despite failure still it continue to proceed
> updating the screen at later stages where vc_data is related to previous
> frame buffer and frame buffer info and display vars are mapped to new
> frame buffer and eventully leading to out-of-bounds write in
> fast_imageblit(). This bheviour is excepted only when fg_console is
> equal to requested console which is a visible console and updates screen
> with invalid struct references in fbcon_putcs().
> 
> Reported-and-tested-by: syzbot+c4b7aa0513823e2ea880@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=c4b7aa0513823e2ea880
> Signed-off-by: Sravan Kumar Gundu <sravankumarlpu@gmail.com>
> ---
>   drivers/video/fbdev/core/fbcon.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)

applied to fbdev git tree.

Thanks!
Helge

      reply	other threads:[~2025-08-02 19:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-31 20:36 [PATCH] fbdev: Fix vmalloc out-of-bounds write in fast_imageblit Sravan Kumar Gundu
2025-08-02 19:30 ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69c344cd-acf4-4363-b4a5-d07226fff609@gmx.de \
    --to=deller@gmx.de \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=skhan@linuxfoundation.com \
    --cc=sravankumarlpu@gmail.com \
    --cc=syzbot+c4b7aa0513823e2ea880@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox