Re: [PATCH] scsi: hisi_sas: use sysfs_emit() in v3 hw show() functions

Khaled Elnaggar
2025-07-12T15:17:06Z

On 12/07/2025 5:43 pm, Greg KH wrote:
> On Sat, Jul 12, 2025 at 05:28:03PM +0300, Khaled Elnaggar wrote:
>> Replace scnprintf() with sysfs_emit() in several sysfs show()
>> callbacks in hisi_sas_v3_hw.c. This is recommended in
>> Documentation/filesystems/sysfs.rst for formatting values returned to
>> userspace.
>
> For new users, yes, but what's wrong with these existing calls? They
> still work properly, so why change them?
>
> thanks,
>
> greg k-h

Oh okay, got it. I was under the impression that older scnprintf()
calls should be actively replaced with sysfs_emit(). But no need if
they just work, unless there is a bug or something.

Thanks for the clarification.