Re: [PATCH] scsi: hisi_sas: use sysfs_emit() in v3 hw show() functions

Greg KH
2025-07-14T05:32:07Z

On Sun, Jul 13, 2025 at 10:58:54AM -0700, Bart Van Assche wrote:
> On 7/12/25 7:43 AM, Greg KH wrote:
> > On Sat, Jul 12, 2025 at 05:28:03PM +0300, Khaled Elnaggar wrote:
> > > Replace scnprintf() with sysfs_emit() in several sysfs show()
> > > callbacks in hisi_sas_v3_hw.c. This is recommended in
> > > Documentation/filesystems/sysfs.rst for formatting values returned to
> > > userspace.
> >
> > For new users, yes, but what's wrong with these existing calls? They
> > still work properly, so why change them?
>
> How about making this explicit in Documentation/filesystems/sysfs.rst?
> I think that would help to stop the steady stream of patches for
> converting existing sysfs show callbacks to sysfs_emit()/sysfs_emit_at().

Patches gladly accepted :)