From: Jonathan Corbet <corbet@lwn.net>
To: Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
khalid@kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
skhan@linuxfoundation.org, david.hunter.linux@gmail.com,
bhanuseshukumar@gmail.com
Subject: Re: [PATCH] docs: Makefile: Sort Documentation targets case-insensitively in make help
Date: Wed, 29 Oct 2025 10:18:48 -0600 [thread overview]
Message-ID: <874irhr89j.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20251015012922.19467-1-bhanuseshukumar@gmail.com>
Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com> writes:
> Avoid case-sensitive sorting when listing Documentation targets in make help.
> Previously, targets like PCI and RCU appeared ahead of others due to uppercase
> names.
>
> Normalize casing during _SPHINXDIRS generation to ensure consistent and
> intuitive ordering.
>
> Fixes: 965fc39f7393 ("Documentation: sort _SPHINXDIRS for 'make help'")
> Signed-off-by: Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>
> ---
> Notes
> - Patch is tested with make help command.
> - Verified case-insensitive sorting.
>
> Documentation/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index 3609cb86137b..00c81e7947a9 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -23,7 +23,7 @@ SPHINXOPTS =
> SPHINXDIRS = .
> DOCS_THEME =
> DOCS_CSS =
> -_SPHINXDIRS = $(sort $(patsubst $(srctree)/Documentation/%/index.rst,%,$(wildcard $(srctree)/Documentation/*/index.rst)))
> +_SPHINXDIRS = $(shell printf "%s\n" $(patsubst $(srctree)/Documentation/%/index.rst,%,$(wildcard $(srctree)/Documentation/*/index.rst)) | sort -f)
> SPHINX_CONF = conf.py
> PAPER =
> BUILDDIR = $(obj)/output
I'm unconvinced that the extra complexity is really needed ... but I
went to apply it anyway. Unfortunately, this patch doesn't apply to
docs-next.
Thanks,
jon
prev parent reply other threads:[~2025-10-29 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 1:29 [PATCH] docs: Makefile: Sort Documentation targets case-insensitively in make help Bhanu Seshu Kumar Valluri
2025-10-27 5:27 ` Bhanu Seshu Kumar Valluri
2025-10-27 5:55 ` Randy Dunlap
2025-10-29 16:18 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874irhr89j.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=bhanuseshukumar@gmail.com \
--cc=david.hunter.linux@gmail.com \
--cc=khalid@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox