Re: [PATCH] docs: Makefile: Sort Documentation targets case-insensitively in make help

Randy Dunlap
2025-10-27T05:55:57Z

On 10/26/25 10:27 PM, Bhanu Seshu Kumar Valluri wrote:
> On 15/10/25 06:59, Bhanu Seshu Kumar Valluri wrote:
>> Avoid case-sensitive sorting when listing Documentation targets in make help.
>> Previously, targets like PCI and RCU appeared ahead of others due to uppercase
>> names.
>>
>> Normalize casing during _SPHINXDIRS generation to ensure consistent and
>> intuitive ordering.
>>
>> Fixes: 965fc39f7393 ("Documentation: sort _SPHINXDIRS for 'make help'")
>> Signed-off-by: Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>
>> ---
>> Notes
>> - Patch is tested with make help command.
>> - Verified case-insensitive sorting.
>>
>> Documentation/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/Makefile b/Documentation/Makefile
>> index 3609cb86137b..00c81e7947a9 100644
>> --- a/Documentation/Makefile
>> +++ b/Documentation/Makefile
>> @@ -23,7 +23,7 @@ SPHINXOPTS =
>> SPHINXDIRS = .
>> DOCS_THEME =
>> DOCS_CSS =
>> -_SPHINXDIRS = $(sort $(patsubst $(srctree)/Documentation/%/index.rst,%,$(wildcard $(srctree)/Documentation/*/index.rst)))
>> +_SPHINXDIRS = $(shell printf "%s\n" $(patsubst $(srctree)/Documentation/%/index.rst,%,$(wildcard $(srctree)/Documentation/*/index.rst)) | sort -f)
>> SPHINX_CONF = conf.py
>> PAPER =
>> BUILDDIR = $(obj)/output
> Hi,
>
> I just wanted to check if you had a chance to review the patch or if any changes are needed from my side.

It's OK with me and it works.

Tested-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>

--
~Randy