From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2F763D6CDA for ; Tue, 2 Jun 2026 10:35:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.138 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780396527; cv=none; b=KSFOEWWm82bD/7LsUAQgUeZl6LLsmdYw2Bmq5fgiLobt6CF7cX97tF5+TBMltInOfRpyEMSYowsSZliaHGM7noaBXbRqrmeLGpGdBkJckBQSzJdDCONg3HLAt757D5qpezbjfyCxNG8A0ZkoPiRZaS/7s4kBkIIiENHvotvHoYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780396527; c=relaxed/simple; bh=7fs/Ea2xnzRuG59u8rGS1g7Z3TJFNLOo7lJohh/sZWI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=aZYCzZTD9Wm0b4W+fkohzkU7NAwz9Q3Mq9qFP9qTimB26XRc+rJmdV0UWM4MglnHvhbfVIujmDvZiOZ4ZI6l6NrDrDoBVO86Vgt9ogEu0fAZmzE1ij5u48kAa+IfmIJsApM6063YzNxaYky6lMIebOyaXN8rs6dwreX/LSQql1g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=uu56T2d5; arc=none smtp.client-ip=140.211.166.138 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="uu56T2d5" Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 483E8810F6 for ; Tue, 2 Jun 2026 10:35:25 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org X-Spam-Flag: NO X-Spam-Score: -5.793 X-Spam-Level: Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id sF9zg4TQ5CL4 for ; Tue, 2 Jun 2026 10:35:24 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=185.171.202.116; helo=smtpout-04.galae.net; envelope-from=miquel.raynal@bootlin.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org C73B1810D3 Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C73B1810D3 Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=uu56T2d5 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) by smtp1.osuosl.org (Postfix) with ESMTPS id C73B1810D3 for ; Tue, 2 Jun 2026 10:35:22 +0000 (UTC) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 38CC2C6247F; Tue, 2 Jun 2026 10:35:22 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id C3F45603BC; Tue, 2 Jun 2026 10:35:19 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 206C11088838A; Tue, 2 Jun 2026 12:35:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1780396518; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=7fs/Ea2xnzRuG59u8rGS1g7Z3TJFNLOo7lJohh/sZWI=; b=uu56T2d5YgNJVXUPff3eP585cqUQLhOxT2qCEPxRjavLP7bnKePVomqANOhLXHIhL1U3sY Ho+JgdHH8q8YJo421XNOeygddbsv+uD3e3k7n6kDOlO+VEzVNJn5P5luXwUymxETNnB4C8 TeRiFEDs2HM1rDYvobbwNHjJn6iujBf05zfw2ILIfbx34etJA2ITdRL8qHMJsFx++yj4i0 +lBfI9G0nzZRPyAHolNhVVyT+Uw2pjV2hQR16rmPviXm9ltIIWMU62wI1jzUBiA/9PTNx1 MvbZunzeY6p6vQMdq/AIOpyQ6HcIDQM+/iLhJxpVS6f1HlXcInvbdfYTYpzdCw== From: Miquel Raynal To: Robertus Diawan Chris Cc: alex.aring@gmail.com, stefan@datenfreihafen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, me@brighamcampbell.com Subject: Re: [PATCH] mac802154: Prevent overwrite return code in mac802154_perform_association() In-Reply-To: <20260602054133.470293-1-robertusdchris@gmail.com> (Robertus Diawan Chris's message of "Tue, 2 Jun 2026 12:41:33 +0700") References: <20260602054133.470293-1-robertusdchris@gmail.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Tue, 02 Jun 2026 12:35:12 +0200 Message-ID: <87ik81mdr3.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel-mentees@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hello, On 02/06/2026 at 12:41:33 +07, Robertus Diawan Chris wrote: > When assoc_status not equal to IEEE802154_ASSOCIATION_SUCCESSFUL, the > return value assigned to either "-ERANGE" or "-EPERM" but this return > value will be overwritten to 0 after exiting the conditional scope. > So, jump to clear_assoc label to preserve the return value when > assoc_status not equal to IEEE802154_ASSOCIATION_SUCCESSFUL. > > This is reported by Coverity Scan as "Unused value". > > Fixes: fefd19807fe9 ("mac802154: Handle associating") > Signed-off-by: Robertus Diawan Chris This is correct. Reviewed-by: Miquel Raynal Thanks, Miqu=C3=A8l