* [PATCH] ALSA: cs4281: Send the PCM period elapsed notification properly
@ 2025-09-06 16:21 Chandra Mohan Sundar
2025-09-06 17:56 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Chandra Mohan Sundar @ 2025-09-06 16:21 UTC (permalink / raw)
To: perex, tiwai, phasta, linux-sound, shuah
Cc: Chandra Mohan Sundar, linux-kernel-mentees
As part of spin lock code cleanup using guard(), a new
variable (period_elapsed) was introduced. However this variable
is never set, causing period elapsed notification to be not sent.
Set the value of period_elapsed appropiately.
This issue was reported by static coverity analyzer.
Fixes: 7a5127c2c8a5a ("ALSA: cs4281: Use guard() for spin locks")
Signed-off-by: Chandra Mohan Sundar <chandramohan.explore@gmail.com>
---
sound/pci/cs4281.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/cs4281.c b/sound/pci/cs4281.c
index c519fb9cdd1e..d00b2c9fb1e3 100644
--- a/sound/pci/cs4281.c
+++ b/sound/pci/cs4281.c
@@ -1752,6 +1752,7 @@ static irqreturn_t snd_cs4281_interrupt(int irq, void *dev_id)
chip->spurious_dtc_irq++;
continue;
}
+ period_elapsed = true;
}
if (period_elapsed)
snd_pcm_period_elapsed(cdma->substream);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: cs4281: Send the PCM period elapsed notification properly
2025-09-06 16:21 [PATCH] ALSA: cs4281: Send the PCM period elapsed notification properly Chandra Mohan Sundar
@ 2025-09-06 17:56 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2025-09-06 17:56 UTC (permalink / raw)
To: Chandra Mohan Sundar
Cc: perex, tiwai, phasta, linux-sound, shuah, linux-kernel-mentees
On Sat, 06 Sep 2025 18:21:54 +0200,
Chandra Mohan Sundar wrote:
>
> As part of spin lock code cleanup using guard(), a new
> variable (period_elapsed) was introduced. However this variable
> is never set, causing period elapsed notification to be not sent.
>
> Set the value of period_elapsed appropiately.
>
> This issue was reported by static coverity analyzer.
>
> Fixes: 7a5127c2c8a5a ("ALSA: cs4281: Use guard() for spin locks")
> Signed-off-by: Chandra Mohan Sundar <chandramohan.explore@gmail.com>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-06 17:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-06 16:21 [PATCH] ALSA: cs4281: Send the PCM period elapsed notification properly Chandra Mohan Sundar
2025-09-06 17:56 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox