public inbox for linux-kernel-mentees@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: Abhishek Tamboli <abhishektamboli9@gmail.com>,
	neil.armstrong@linaro.org, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
	daniel@ffwll.ch
Cc: quic_jesszhan@quicinc.com, skhan@linuxfoundation.org,
	rbmarliere@gmail.com,
	linux-kernel-mentees@lists.linuxfoundation.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panel: hx83112a: Switch to wrapped mipi_dsi functions
Date: Tue, 03 Sep 2024 11:17:37 +0200	[thread overview]
Message-ID: <87plplgkpa.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <20240902170153.34512-1-abhishektamboli9@gmail.com>

Abhishek Tamboli <abhishektamboli9@gmail.com> writes:

Hello Abhishek

> Use the new mipi_dsi_*_multi wrapped function in hx83112a_on
> and hx83112a_disable function.
>

IMO commit messages should explain why the change is needed and
not just what the patch is changing (for this one can just look
at the diffstat).

> Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
> ---

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


  reply	other threads:[~2024-09-03  9:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-02 17:01 [PATCH] drm/panel: hx83112a: Switch to wrapped mipi_dsi functions Abhishek Tamboli
2024-09-03  9:17 ` Javier Martinez Canillas [this message]
2024-09-03 17:30   ` Abhishek Tamboli
2024-09-03 13:42 ` kernel test robot
2024-09-03 16:59 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plplgkpa.fsf@minerva.mail-host-address-is-not-set \
    --to=javierm@redhat.com \
    --cc=abhishektamboli9@gmail.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_jesszhan@quicinc.com \
    --cc=rbmarliere@gmail.com \
    --cc=skhan@linuxfoundation.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox