From: David Hunter <david.hunter.linux@gmail.com>
To: vivekyadav1207731111@gmail.com, johan@kernel.org,
gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH] usb: serial: fix: trainling statements `break` should be on next line
Date: Mon, 6 Oct 2025 21:16:26 -0400 [thread overview]
Message-ID: <8fea55a9-54f8-405b-9844-ee67b5e43ba3@gmail.com> (raw)
In-Reply-To: <20251004080123.98285-1-vivekyadav1207731111@gmail.com>
On 10/4/25 04:01, vivekyadav1207731111@gmail.com wrote:
> + case 300:
> + case 600:
> + case 1200:
> + case 2400:
> + case 4800:
> + case 9600:
> + case 19200:
> + case 38400:
> + case 57600:
> + case 115200:
> + break;
It is generally considered best practice to use the breaks after each
case. Here is a good article on this:
https://lwn.net/Articles/794944/
Also, same here. no top-posting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
prev parent reply other threads:[~2025-10-07 1:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-04 8:01 [PATCH] usb: serial: fix: trainling statements `break` should be on next line vivekyadav1207731111
2025-10-06 12:13 ` Johan Hovold
2025-10-06 17:55 ` vivek yadav
2025-10-07 1:16 ` David Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fea55a9-54f8-405b-9844-ee67b5e43ba3@gmail.com \
--to=david.hunter.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vivekyadav1207731111@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox