public inbox for linux-kernel-mentees@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Alex Hung <alex.hung@amd.com>
To: James <bold.zone2373@fastmail.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	sunpeng.li@amd.com, "Rodrigo Siqueira" <siqueira@igalia.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	airlied@gmail.com, simona@ffwll.ch, alvin.lee2@amd.com,
	zaeem.mohamed@amd.com, "Shuah Khan" <skhan@linuxfoundation.org>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH v2] drm/amd/display: adds kernel-doc comment for dc_stream_remove_writeback()
Date: Tue, 20 May 2025 09:28:05 -0600	[thread overview]
Message-ID: <9d80b11c-99db-432d-a9ff-d9e2a7b463bb@amd.com> (raw)
In-Reply-To: <458ee98c-872c-44eb-81a4-cb1fabcc4704@app.fastmail.com>



On 5/19/25 20:06, James wrote:
> 
> 
> On Mon, May 5, 2025, at 9:02 AM, Alex Hung wrote:
>> Reviewed-by: Alex Hung <alex.hung@amd.com>
>>
>> On 5/3/25 15:18, James Flowers wrote:
>>> Adds kernel-doc for externally linked dc_stream_remove_writeback function.
>>>
>>> Signed-off-by: James Flowers <bold.zone2373@fastmail.com>
>>> ---
>>> V1 -> V2: Corrected checkpatch warnings and errors
>>>
>>>    drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 ++++++++
>>>    1 file changed, 8 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>>> index e6e41678525f..b883fb24fa12 100644
>>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>>> @@ -569,6 +569,14 @@ bool dc_stream_fc_disable_writeback(struct dc *dc,
>>>    	return true;
>>>    }
>>>    
>>> +/**
>>> + * dc_stream_remove_writeback() - Disables writeback and removes writeback info.
>>> + * @dc: Display core control structure.
>>> + * @stream: Display core stream state.
>>> + * @dwb_pipe_inst: Display writeback pipe.
>>> + *
>>> + * Return: returns true on success, false otherwise.
>>> + */
>>>    bool dc_stream_remove_writeback(struct dc *dc,
>>>    		struct dc_stream_state *stream,
>>>    		uint32_t dwb_pipe_inst)
> 
> Hi,
> 
> I am just following up on this to see if it’s been applied, or if any adjustments are still needed.

It's in amd-staging-drm-next: 
https://gitlab.freedesktop.org/agd5f/linux/-/commit/04abe7201d51a094d0edd3e00399a8afa2cd2d4f

> 
> Best regards,
> James Flowers


      reply	other threads:[~2025-05-20 15:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-03 21:18 [PATCH v2] drm/amd/display: adds kernel-doc comment for dc_stream_remove_writeback() James Flowers
2025-05-05 16:02 ` Alex Hung
2025-05-20  2:06   ` James
2025-05-20 15:28     ` Alex Hung [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d80b11c-99db-432d-a9ff-d9e2a7b463bb@amd.com \
    --to=alex.hung@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=alvin.lee2@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bold.zone2373@fastmail.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=siqueira@igalia.com \
    --cc=skhan@linuxfoundation.org \
    --cc=sunpeng.li@amd.com \
    --cc=zaeem.mohamed@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox