public inbox for linux-kernel-mentees@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: "Brigham Campbell" <me@brighamcampbell.com>
To: "David Hunter" <david.hunter.linux@gmail.com>,
	"Hanne-Lotta Mäenpää" <hannelotta@gmail.com>,
	mchehab@kernel.org
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-kernel-mentees@lists.linux.dev>,
	<skhan@linuxfoundation.org>
Subject: Re: [PATCH v4] media: Documentation: Improve grammar in DVB API
Date: Thu, 10 Jul 2025 17:55:47 -0600	[thread overview]
Message-ID: <DB8S4WLTG1SS.NVODTL6KNFXF@brighamcampbell.com> (raw)
In-Reply-To: <680b91c0-0fae-4230-9fa1-da988cb82e65@gmail.com>

On Wed Jul 9, 2025 at 10:22 PM MDT, David Hunter wrote:
> On 7/8/25 11:52, Hanne-Lotta Mäenpää wrote:
>> Fix typos and punctuation and improve grammar in documentation.
>> 
>> Signed-off-by: Hanne-Lotta Mäenpää <hannelotta@gmail.com>
>
> Overall, good work. Here is a suggestion for future patch series:
>
> Subsequent versions of patch series should be posted as replies in the same thread. Currently, each version is its own independent thread, which makes it hard to track changes. This link has the documentation for the proper way to handle subsequent patches:
>
> https://www.kernel.org/pub/software/scm/git/docs/SubmittingPatches.html
>
> The relevant part starts at "To that end, send them as replies to either..."

This documentation you've linked is specific to git, not the linux
kernel.

The kernel documentation argues against doing what you suggest [1]: "for
a multi-patch series, it is generally best to avoid using In-Reply-To:
to link to older versions of the series. This way multiple versions of
the patch don’t become an unmanageable forest of references in email
clients."

[1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html

>
> Another good practice is to have the previous versions' links from "lore.kernel.org" directly in the change log. 
>
> Thanks, 
> David Hunter

Nice work, as usual, Hanne-Lotta.

Brigham


  parent reply	other threads:[~2025-07-10 23:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-08 15:52 [PATCH v4] media: Documentation: Improve grammar in DVB API Hanne-Lotta Mäenpää
2025-07-10  4:22 ` David Hunter
2025-07-10 13:44   ` Hanne-Lotta Mäenpää
2025-07-10 23:55   ` Brigham Campbell [this message]
2025-07-11 17:05     ` Hanne-Lotta Mäenpää

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB8S4WLTG1SS.NVODTL6KNFXF@brighamcampbell.com \
    --to=me@brighamcampbell.com \
    --cc=david.hunter.linux@gmail.com \
    --cc=hannelotta@gmail.com \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox