From: "Brigham Campbell" <me@brighamcampbell.com>
To: "Doug Anderson" <dianders@chromium.org>
Cc: <maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <airlied@gmail.com>, <simona@ffwll.ch>,
<linus.walleij@linaro.org>, <neil.armstrong@linaro.org>,
<jessica.zhang@oss.qualcomm.com>, <sam@ravnborg.org>,
<skhan@linuxfoundation.org>,
<linux-kernel-mentees@lists.linux.dev>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] drm: Create mipi_dsi_dcs_read_multi()
Date: Sun, 27 Jul 2025 18:48:10 -0600 [thread overview]
Message-ID: <DBN9W9SJU6MX.F5UH2D1QCJNC@brighamcampbell.com> (raw)
In-Reply-To: <CAD=FV=UZqzWd+Ke2sU-z86jnhKhUo8v0ChyKYnGpmx+s7n0stQ@mail.gmail.com>
On Fri Jul 25, 2025 at 3:16 PM MDT, Doug Anderson wrote:
>> + dev_err(dev, "transferring dcs message %xh failed: %d\n", cmd,
>
> Format code "%xh" is probably not exactly what you want. If the error
> code is 0x10 it will print 10h, which is not very standard. You
> probably copied it from the write routine which uses "%*ph". There the
> "h" means something. See Documentation/core-api/printk-formats.rst.
> Probably you want "%#x".
Ah yes, I had based this change off the "%*ph" format specifier and I
had mistakenly assumed that the 'h' was a literal 'h'. I'll fix that in
v2.
> I'd probably also say "dcs read with cmd" rather than "transferring
> dcs message".
Yes, this sounds more accurate. I'll include this in v2 as well.
Thanks for the review,
Brigham
next prev parent reply other threads:[~2025-07-28 0:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 20:23 [PATCH 0/2] drm/panel: novatek-nt35560: Fix bug and clean up Brigham Campbell
2025-07-24 20:23 ` [PATCH 1/2] drm: Create mipi_dsi_dcs_read_multi() Brigham Campbell
2025-07-25 21:16 ` Doug Anderson
2025-07-28 0:48 ` Brigham Campbell [this message]
2025-07-24 20:23 ` [PATCH 2/2] drm/panel: novatek-nt35560: Fix bug and clean up Brigham Campbell
2025-07-25 21:17 ` Doug Anderson
2025-07-28 6:04 ` Brigham Campbell
2025-07-28 16:28 ` Doug Anderson
2025-07-25 21:16 ` [PATCH 0/2] " Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBN9W9SJU6MX.F5UH2D1QCJNC@brighamcampbell.com \
--to=me@brighamcampbell.com \
--cc=airlied@gmail.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=sam@ravnborg.org \
--cc=simona@ffwll.ch \
--cc=skhan@linuxfoundation.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox