Re: [PATCH 0/2] drm/panel: novatek-nt35560: Fix bug and clean up

Doug Anderson
2025-07-25T21:17:18Z

Hi,

On Thu, Jul 24, 2025 at 1:23 PM Brigham Campbell <me@brighamcampbell.com> wrote:
>
> This series does the following:
> - Add mipi_dsi_dcs_read_multi() to drm_mipi_dsi.c for improved error
> handling in drivers which use mipi_dsi_dcs_read() such as the
> novatek-nt35560 driver.
> - Fix a bug in nt35560_set_brightness() which causes the driver to
> incorrectly report that it "failed to disable display backlight".
> - Clean up novatek-nt35560 driver to use "multi" variants of MIPI
> functions which promote cleaner code.
>
> If there's a reason that mipi_dsi_dcs_read_multi doesn't exist, I'm
> happy to drop it.

It's a _little_ weird since one would normally assume that the caller
would want to immediately act on whatever was read and to do that
they'd need to look at the error code right away.

...but then again, there are places where a driver might want to read
multiple things and then check for errors once in the end (like the
driver you're changing here does). So I'm not against it. I'm not sure
I'd expect it to be universally used, though...