From: "Brigham Campbell" <me@brighamcampbell.com>
To: "Doug Anderson" <dianders@chromium.org>
Cc: <maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <airlied@gmail.com>, <simona@ffwll.ch>,
<linus.walleij@linaro.org>, <neil.armstrong@linaro.org>,
<jessica.zhang@oss.qualcomm.com>, <sam@ravnborg.org>,
<skhan@linuxfoundation.org>,
<linux-kernel-mentees@lists.linux.dev>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] drm: Add MIPI support function and macros
Date: Tue, 29 Jul 2025 18:15:17 -0600 [thread overview]
Message-ID: <DBOYG6B6WLDT.Z096YHZGRXDS@brighamcampbell.com> (raw)
In-Reply-To: <CAD=FV=VLoMenu22F_VeoHyfXwRO7JfXL8peQLEpkqeZ1tDOmEQ@mail.gmail.com>
On Tue Jul 29, 2025 at 3:34 PM MDT, Doug Anderson wrote:
>> +/**
>> + * mipi_dsi_generic_write_var_seq_multi - transmit non-static data using a
>> + * generic write packet
>
> nit: "non-constant", not "non-static"
>
> From the caller's point of view the difference is that the data is
> compile-time constant in one case and not compile-time constant in the
> other case. It happens that means you can _store_ it in a "static
> const" in one case and not in the other case, but that doesn't make
> the parameters "static".
Good point. The storage class is an important implementation detail
within drm_mipi_dsi.h, but just that from the perspective of a panel
driver author: an implementation detail. I'll go ahead and address this
and other feedback in v3.
Thanks,
Brigham
next prev parent reply other threads:[~2025-07-30 0:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 5:44 [PATCH v2 0/3] drm/panel: novatek-nt35560: Fix bug and clean up Brigham Campbell
2025-07-29 5:44 ` [PATCH v2 1/3] drm/panel: novatek-nt35560: Fix invalid return value Brigham Campbell
2025-07-29 9:17 ` neil.armstrong
2025-07-29 21:33 ` Doug Anderson
2025-07-30 0:02 ` Brigham Campbell
2025-07-29 5:44 ` [PATCH v2 2/3] drm: Add MIPI support function and macros Brigham Campbell
2025-07-29 21:34 ` Doug Anderson
2025-07-30 0:15 ` Brigham Campbell [this message]
2025-07-29 5:44 ` [PATCH v2 3/3] drm/panel: novatek-nt35560: Clean up driver Brigham Campbell
2025-07-29 21:34 ` Doug Anderson
2025-07-29 17:49 ` [PATCH v2 0/3] drm/panel: novatek-nt35560: Fix bug and clean up Brigham Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBOYG6B6WLDT.Z096YHZGRXDS@brighamcampbell.com \
--to=me@brighamcampbell.com \
--cc=airlied@gmail.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=sam@ravnborg.org \
--cc=simona@ffwll.ch \
--cc=skhan@linuxfoundation.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox