From: Brendan Jackman <jackmanb@google.com>
To: Bala-Vignesh-Reddy <reddybalavignesh9979@gmail.com>,
<naresh.kamboju@linaro.org>, <broonie@kernel.org>,
<bp@alien8.de>, <shuah@kernel.org>
Cc: <anders.roxell@linaro.org>, <arnd@arndb.de>,
<benjamin.copeland@linaro.org>, <bp@alien8.de>,
<dan.carpenter@linaro.org>, <dave.hansen@linux.intel.com>,
<hpa@zytor.com>, <linux-kernel@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>,
<lkft-triage@lists.linaro.org>, <mingo@redhat.com>,
<regressions@lists.linux.dev>, <richard.weiyang@gmail.com>,
<shuah@kernel.org>, <surenb@google.com>, <tglx@linutronix.de>,
<x86@kernel.org>, <linux-kernel-mentees@lists.linux.dev>,
Linux Kernel Functional Testing <lkft@linaro.org>
Subject: Re: [PATCH] selftests/x86: Add selftests include path for kselftest.h after centralization
Date: Mon, 12 Jan 2026 10:27:15 +0000 [thread overview]
Message-ID: <DFMJF68KIIHN.3Y2YF3EXRJ53@google.com> (raw)
In-Reply-To: <20251022062948.162852-1-reddybalavignesh9979@gmail.com>
On Wed Oct 22, 2025 at 6:29 AM UTC, Bala-Vignesh-Reddy wrote:
> The previous change centralizing kselftest.h include path in lib.mk
> caused x86 selftests to fail, as x86 Makefile overwrites CFLAGS using
> ":=", dropping the include path added in lib.mk. Therefore, helpers.h
> could not find kselftest.h during compilation.
>
> Fix this by adding the tools/testing/sefltest to CFLAGS in x86 Makefile.
>
> Fixes: 4d89827dfb27 ("selftests: complete kselftest include centralization")
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Closes: https://lore.kernel.org/lkml/CA+G9fYvKjQcCBMfXA-z2YuL2L+3Qd-pJjEUDX8PDdz2-EEQd=Q@mail.gmail.com/T/#m83fd330231287fc9d6c921155bee16c591db7360
>
> Signed-off-by: Bala-Vignesh-Reddy <reddybalavignesh9979@gmail.com>
Thanks, this fixes the issue I reported here:
https://lore.kernel.org/lkml/DFHI984SEFV3.2JL88CLHNT2SO@google.com/
Tested-by: Brendan Jackman <jackmanb@google.com>
Shuah, does this go via the kselftests tree? If not, Boris can you take
it via x86?
next prev parent reply other threads:[~2026-01-12 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+G9fYvKjQcCBMfXA-z2YuL2L+3Qd-pJjEUDX8PDdz2-EEQd=Q@mail.gmail.com>
2025-10-22 6:29 ` [PATCH] selftests/x86: Add selftests include path for kselftest.h after centralization Bala-Vignesh-Reddy
2025-10-22 15:02 ` Anders Roxell
2026-01-12 10:27 ` Brendan Jackman [this message]
2026-01-17 11:08 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFMJF68KIIHN.3Y2YF3EXRJ53@google.com \
--to=jackmanb@google.com \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=benjamin.copeland@linaro.org \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=lkft@linaro.org \
--cc=mingo@redhat.com \
--cc=naresh.kamboju@linaro.org \
--cc=reddybalavignesh9979@gmail.com \
--cc=regressions@lists.linux.dev \
--cc=richard.weiyang@gmail.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox