From: "Brigham Campbell" <me@brighamcampbell.com>
To: "Sajal Gupta" <sajal2005gupta@gmail.com>,
<linux-raid@vger.kernel.org>, <song@kernel.org>
Cc: <yukuai3@huawei.com>, <tomasz.majchrzak@intel.com>,
<linux-kernel@vger.kernel.org>, <error27@gmail.com>,
<skhan@linuxfoundation.org>, <me@brighamcampbell.com>,
<linux-kernel-mentees@lists.linux.dev>
Subject: Re: [PATCH v2] md/raid5-ppl: fix use-after-free in ppl_do_flush()
Date: Tue, 23 Jun 2026 22:42:47 -0600 [thread overview]
Message-ID: <DJH0687PNY2P.1WOW0ATJ2KZA9@brighamcampbell.com> (raw)
In-Reply-To: <20260622142146.56637-1-sajal2005gupta@gmail.com>
On Mon Jun 22, 2026 at 8:06 AM MDT, Sajal Gupta wrote:
> Compile tested only.
It looks like you're on the right track, but this could use some
testing. My analysis here may be incorrect, but it looks like it should
be pretty easy to test this patch by compiling and running on a system
with a RAID5 array, PPL enabled, and no RAID journal. I expect the call
stack would look something like the following (feel free to correct me,
anyone...):
ppl_do_flush
ppl_stripe_write_finished
log_stripe_write_finished
handle_stripe
...
To be sure, you can add a tracepoint[^1] inside ppl_do_flush.
Dan was probably reluctant to make the change himself, opting to instead
submit a KTODO because the change is relatively straightforward, but
testing is a little more involved. Testing is particularly important
with respect to subsystems pertaining to the filesystem because latent
regressions could mean permanent data loss.
Cheers,
Brigham
[1]: https://docs.kernel.org/trace/tracepoints.html
next prev parent reply other threads:[~2026-06-24 4:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 14:06 [PATCH v2] md/raid5-ppl: fix use-after-free in ppl_do_flush() Sajal Gupta
2026-06-24 4:42 ` Brigham Campbell [this message]
2026-06-24 8:07 ` Dan Carpenter
2026-07-05 9:02 ` yu kuai
2026-07-30 8:09 ` yu kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJH0687PNY2P.1WOW0ATJ2KZA9@brighamcampbell.com \
--to=me@brighamcampbell.com \
--cc=error27@gmail.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=sajal2005gupta@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=song@kernel.org \
--cc=tomasz.majchrzak@intel.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox