From: Greg KH <gregkh@linuxfoundation.org>
To: Aviral Gupta <shiv14112001@gmail.com>
Cc: shuah@kernal.org, linux-fsdevel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] This commit fixes the error generated due to the wrong indentation which does not follow the codding style norms set by Linux-kernel and space- bar is used in place of tab to give space which causes a visual error for some compilers
Date: Fri, 21 May 2021 13:07:35 +0200 [thread overview]
Message-ID: <YKeUd/X5tuN54o1H@kroah.com> (raw)
In-Reply-To: <20210521105654.4046-1-shiv14112001@gmail.com>
On Fri, May 21, 2021 at 04:26:54PM +0530, Aviral Gupta wrote:
> ERROR: switch and case should be at the same indent
> + switch (whence) {
> + case 1:
> [...]
> + case 0:
> [...]
> + default:
> ERROR: code indent should use tabs where possible
> + void (*callback)(struct dentry *))$
>
> Signed-off-by: Aviral Gupta <shiv14112001@gmail.com>
> ---
> fs/libfs.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
Your subject line is very odd.
And why are you trying to change coding style issues in core kernel
code?
Please start this type of work in drivers/staging/ where it is wanted,
not in other areas of the kernel where it is not good to try to learn
the process.
good luck!
greg k-h
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2021-05-21 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 10:56 [PATCH] This commit fixes the error generated due to the wrong indentation which does not follow the codding style norms set by Linux-kernel and space- bar is used in place of tab to give space which causes a visual error for some compilers Aviral Gupta
2021-05-21 11:07 ` Greg KH [this message]
2021-05-21 11:41 ` Pavel Skripkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKeUd/X5tuN54o1H@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shiv14112001@gmail.com \
--cc=shuah@kernal.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox