From: Matthew Wilcox <willy@infradead.org>
To: I Hsin Cheng <richard120310@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
syzbot+de1498ff3a934ac5e8b4@syzkaller.appspotmail.com,
viro@zeniv.linux.org.uk, brauner@kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
jfs-discussion@lists.sourceforge.net, shaggy@kernel.org,
syzkaller-bugs@googlegroups.com, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [RFC PATCH] fs/buffer: Handle non folio buffer case for drop_buffer()
Date: Fri, 25 Apr 2025 21:01:04 +0100 [thread overview]
Message-ID: <aAvqAMBW7fzYkz_o@casper.infradead.org> (raw)
In-Reply-To: <aAu92k-iPbnWBKGz@vaxr-BM6660-BM6360>
On Sat, Apr 26, 2025 at 12:52:42AM +0800, I Hsin Cheng wrote:
> > Can you print more about the folio where this happened? In particular it
> > would be interesting what's in folio->flags, folio->mapping->flags and
> > folio->mapping->aops (resolved to a symbol). Because either the mapping has
> > AS_RELEASE_ALWAYS set but then we should have ->releasepage handler, or
> > have PG_Private bit set without buffers attached to a page but then again
> > either ->releasepage should be set or there's some bug in fs/buffer.c which
> > can set PG_Private without attaching buffers (I don't see where that could
> > be).
> >
>
> Hmm so I suppose when there're buffers attached, the PG_Private bit
> should always be set in folio->flags or folio->mapping->flags or
> folio->mapping->aops ?
See folio_attach_private(). I am trying to get rid of PG_private, but
we're not quite there yet. The other information may help track down
what is going on.
prev parent reply other threads:[~2025-04-25 20:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <66fcb7f9.050a0220.f28ec.04e8.GAE@google.com>
2025-04-23 2:37 ` [RFC PATCH] fs/buffer: Handle non folio buffer case for drop_buffer() I Hsin Cheng
2025-04-23 10:13 ` Jan Kara
2025-04-25 16:52 ` I Hsin Cheng
2025-04-25 20:01 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAvqAMBW7fzYkz_o@casper.infradead.org \
--to=willy@infradead.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=richard120310@gmail.com \
--cc=shaggy@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+de1498ff3a934ac5e8b4@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox