From: Matthew Wilcox <willy@infradead.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: I Hsin Cheng <richard120310@gmail.com>,
brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH] fs: Fix typo in comment of link_path_walk()
Date: Sat, 10 May 2025 22:11:06 +0100 [thread overview]
Message-ID: <aB_A6jiLNBwpeNsJ@casper.infradead.org> (raw)
In-Reply-To: <20250510120835.GY2023217@ZenIV>
On Sat, May 10, 2025 at 01:08:35PM +0100, Al Viro wrote:
> On Sat, May 10, 2025 at 06:46:32PM +0800, I Hsin Cheng wrote:
> > Fix "NUL" to "NULL".
> >
> > Fixes: 200e9ef7ab51 ("vfs: split up name hashing in link_path_walk() into helper function")
>
> Not a typo. And think for a second about the meaning of
> so "fixed" sentence - NUL and '/' are mutually exclusive
> alternatives; both are characters. NULL is a pointer and
> makes no sense whatsoever in that context.
fwiw, C refers to strings as being 'null terminated' rather than NUL
terminated. eg 5.2.1:
"A byte with all bits set to 0, called the null character, shall exist
in the basic execution character set; it is used to terminate a character
string."
so NULL-terminated is incorrect because it uses the wrong case. All this
to sau. I Hsin Cheng, please do not submit patches "correcting" comments
in the other direction (ie changing NULL to NUL). They aren't
ambiguous.
prev parent reply other threads:[~2025-05-10 21:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-10 10:46 [PATCH] fs: Fix typo in comment of link_path_walk() I Hsin Cheng
2025-05-10 12:08 ` Al Viro
2025-05-10 12:44 ` I Hsin Cheng
2025-05-10 17:48 ` Al Viro
2025-05-10 21:11 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aB_A6jiLNBwpeNsJ@casper.infradead.org \
--to=willy@infradead.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=richard120310@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox