From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Abdelrahman Fekry <abdelrahmanfekry375@gmail.com>
Cc: andy@kernel.org, hdegoede@redhat.com, mchehab@kernel.org,
sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org,
linux-kernel-mentees@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, skhan@linuxfoundation.com,
dan.carpenter@linaro.org, Hans de Goede <hansg@kernel.org>
Subject: Re: [PATCH v4] staging: media: atomisp: remove debug sysfs attributes active_bo and free_bo
Date: Fri, 27 Jun 2025 11:40:04 +0300 [thread overview]
Message-ID: <aF5Y5MurVIn1mUk1@smile.fi.intel.com> (raw)
In-Reply-To: <20250627072939.21447-1-abdelrahmanfekry375@gmail.com>
On Fri, Jun 27, 2025 at 10:29:39AM +0300, Abdelrahman Fekry wrote:
> The sysfs attributes active_bo and free_bo expose internal buffer
> state used only for debugging purposes. These are not part of
> any standard kernel ABI, and need to be removed before this
> driver may be moved out of drivers/staging.
>
> - Remove active_bo and free_bo attributes
> - Remove group registration calls form hmm_init() and hmm_cleanup()
...
> /* free dummy memory first */
> hmm_free(dummy_ptr);
> dummy_ptr = 0;
> -
> hmm_bo_device_exit(&bo_device);
> hmm_initialized = false;
Stray change.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-27 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 7:29 [PATCH v4] staging: media: atomisp: remove debug sysfs attributes active_bo and free_bo Abdelrahman Fekry
2025-06-27 8:40 ` Andy Shevchenko [this message]
2025-06-27 9:03 ` Abdelrahman Fekry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF5Y5MurVIn1mUk1@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=abdelrahmanfekry375@gmail.com \
--cc=andy@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=skhan@linuxfoundation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox