From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Abdelrahman Fekry <abdelrahmanfekry375@gmail.com>
Cc: andy@kernel.org, hdegoede@redhat.com, mchehab@kernel.org,
sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, shuah@linuxfoundation.org,
linux-kernel-mentees@lists.linux.dev, dan.carpenter@linaro.org
Subject: Re: [PATCH] staging: media: atomisp: remove debug sysfs attributes active_bo and free_bo
Date: Tue, 24 Jun 2025 16:24:59 +0300 [thread overview]
Message-ID: <aFqnK5nIHilUSxPq@smile.fi.intel.com> (raw)
In-Reply-To: <20250624130841.34693-1-abdelrahmanfekry375@gmail.com>
On Tue, Jun 24, 2025 at 04:08:41PM +0300, Abdelrahman Fekry wrote:
> The sysfs attributes active_bo and free_bo expose internal buffer
> state used only for debugging purposes. These are not part of
> any standard kernel ABI and needs to be removed before this
> driver can be moved out of drivers/staging.
>
> - Remove active_bo and free_bo attributes
> - Remove group registration calls form hmm_init() and hmm_cleanup()
Suggested-by: ?
...
> + /* Removed sysfs group registration for active_bo and free_bo attributes */
> +
> + /* Removed sysfs group remove for active_bo and free_bo attributes */
These comments do not bring a value, no need to have them.
With the above fixed,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-24 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 13:08 [PATCH] staging: media: atomisp: remove debug sysfs attributes active_bo and free_bo Abdelrahman Fekry
2025-06-24 13:24 ` Andy Shevchenko [this message]
2025-06-24 14:30 ` Abdelrahman Fekry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFqnK5nIHilUSxPq@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=abdelrahmanfekry375@gmail.com \
--cc=andy@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shuah@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox