From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: "Akshay Bansod" <akbansd@gmail.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: st_lsm6dsx: Replace scnprintf with sysfs_emit
Date: Wed, 2 Jul 2025 17:55:44 +0300 [thread overview]
Message-ID: <aGVIcBLgXZj_YR7B@smile.fi.intel.com> (raw)
In-Reply-To: <f96b68a5-d750-45f0-8cdd-9761b5daca1d@baylibre.com>
On Wed, Jul 02, 2025 at 09:16:51AM -0500, David Lechner wrote:
> On 7/2/25 8:58 AM, Akshay Bansod wrote:
> > Update the sysfs interface for sampling frequency and scale attributes.
> > Replace `scnprintf()` with `sysfs_emit_at()` which is PAGE_SIZE-aware
> > and recommended for use in sysfs.
...
> > + len += sysfs_emit_at(buf, len, "%d.%03d ",
> > odr_table->odr_avl[i].milli_hz / 1000,
> > odr_table->odr_avl[i].milli_hz % 1000);
>
> Let's keep checkpatch happy and change the indent of the wrapped lines to
> line up with ( since the ( moved.
While I see the point, wouldn't be better to have 1000 replaced with MILLI
at the same time?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-07-02 14:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 13:58 [PATCH] iio: st_lsm6dsx: Replace scnprintf with sysfs_emit Akshay Bansod
2025-07-02 14:16 ` David Lechner
2025-07-02 14:55 ` Andy Shevchenko [this message]
2025-07-02 15:04 ` David Lechner
2025-07-02 15:22 ` Andy Shevchenko
2025-07-02 15:33 ` Jonathan Cameron
2025-07-02 15:53 ` David Lechner
2025-07-03 9:05 ` Andy Shevchenko
2025-07-03 12:31 ` David Lechner
2025-07-02 14:57 ` akshay bansod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGVIcBLgXZj_YR7B@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=akbansd@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox