From: Dave Chinner <david@fromorbit.com>
To: Marcelo Moreira <marcelomoreira1905@gmail.com>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] xfs: Replace strncpy with strscpy
Date: Fri, 18 Jul 2025 21:16:08 +1000 [thread overview]
Message-ID: <aHos-A3d0T6qcL0o@dread.disaster.area> (raw)
In-Reply-To: <CAPZ3m_gL-K1d2r1YSZhFXmy4v3xHs5uigGOmC2TdsAAoZx+Tyg@mail.gmail.com>
On Thu, Jul 17, 2025 at 02:34:25PM -0300, Marcelo Moreira wrote:
> Given that the original `strncpy()` is safe and correctly implemented
> for this context, and understanding that `memcpy()` would be the
> correct replacement if a change were deemed necessary for
> non-NUL-terminated raw data, I have a question:
>
> Do you still think a replacement is necessary here, or would you
> prefer to keep the existing `strncpy()` given its correct and safe
> usage in this context? If a replacement is preferred, I will resubmit
> a V2 using `memcpy()` instead.
IMO: if it isn't broken, don't try to fix it. Hence I -personally-
wouldn't change it.
However, modernisation and cleaning up of the code base to be
consistent is a useful endeavour. So from this perspective replacing
strncpy with memcpy() would be something I'd consider an acceptible
change.
Largely it is up to the maintainer to decide.....
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2025-07-18 11:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 18:20 [PATCH] xfs: Replace strncpy with strscpy Marcelo Moreira
2025-07-16 23:52 ` Dave Chinner
2025-07-17 17:34 ` Marcelo Moreira
2025-07-18 11:16 ` Dave Chinner [this message]
2025-07-18 19:10 ` Marcelo Moreira
2025-07-20 13:35 ` Carlos Maiolino
2025-07-20 22:24 ` Marcelo Moreira
2025-07-17 16:39 ` Darrick J. Wong
2025-07-17 17:36 ` Marcelo Moreira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHos-A3d0T6qcL0o@dread.disaster.area \
--to=david@fromorbit.com \
--cc=cem@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=marcelomoreira1905@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox