From: Christoph Hellwig <hch@infradead.org>
To: Marcelo Moreira <marcelomoreira1905@gmail.com>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v2] xfs: Replace strncpy with memcpy
Date: Sun, 17 Aug 2025 21:43:57 -0700 [thread overview]
Message-ID: <aKKvjVfm9IPw9UAg@infradead.org> (raw)
In-Reply-To: <20250817155053.15856-1-marcelomoreira1905@gmail.com>
On Sun, Aug 17, 2025 at 12:50:41PM -0300, Marcelo Moreira wrote:
> Following a suggestion from Dave and everyone who contributed to v1, this
> changes modernizes the code by aligning it with current kernel best practices.
> It improves code clarity and consistency, as strncpy is deprecated as explained
> in Documentation/process/deprecated.rst. Furthermore, this change was tested
> by xfstests and as it was not an easy task I decided to document on my blog
> the step by step of how I did it https://meritissimo1.com/blog/2-xfs-tests :).
I tried to follow the link, but got a warning about a potential security
threat because firefox doesn't trust the SSL certificate. But maybe you
can add what you wrote up to the xfstests README or a new file linked
from it to help everyone using it first time?
Either way this probably shouldn't be in this kernel commit log.
The change itself looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-08-18 4:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <DgC9ldLgYmvzXaAZpH-XsBCKhwKSRirv1SdyNKAyWkv0buVk8ZXruCVWp7pYeSa6Ogg-jj6hxYTLAxC0m0FYeg==@protonmail.internalid>
2025-08-17 15:50 ` [PATCH v2] xfs: Replace strncpy with memcpy Marcelo Moreira
2025-08-18 4:43 ` Christoph Hellwig [this message]
2025-08-18 4:46 ` Christoph Hellwig
2025-08-20 13:47 ` Marcelo Moreira
2025-08-21 8:47 ` Christoph Hellwig
2025-08-23 17:41 ` Marcelo Moreira
2025-08-21 9:39 ` Carlos Maiolino
2025-08-23 17:34 ` Marcelo Moreira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKKvjVfm9IPw9UAg@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=marcelomoreira1905@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox