public inbox for linux-kernel-mentees@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Ankan Biswas <spyjetfayed@gmail.com>,
	Lasse Collin <lasse.collin@tukaani.org>
Cc: lasse.collin@tukaani.org, skhan@linuxfoundation.org,
	khalid@kernel.org, david.hunter.linux@gmail.com,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH v2] lib/xz: remove dead IA-64 (Itanium) support code
Date: Tue, 14 Oct 2025 04:25:29 +0800	[thread overview]
Message-ID: <aO1gOckA14Ed/26F@visitorckw-System-Product-Name> (raw)
In-Reply-To: <20251013173446.8692-1-spyjetfayed@gmail.com>

On Mon, Oct 13, 2025 at 11:01:58PM +0530, Ankan Biswas wrote:
> Support for the IA-64 (Itanium) architecture was removed in
> commit cf8e8658100d ("arch: Remove Itanium (IA-64) architecture").
> 
> This patch drops the IA-64 specific decompression code from
> lib/xz, which was conditionally compiled with the now-obsolete
> CONFIG_XZ_DEC_IA64 option.
> 
> Note that the upstream version of xz_dec_bcj.c still retains support
> for the IA-64 BCJ filter.

Not sure if it's necessary to mention this, but I guess it's fine.

> 
> Signed-off-by: Ankan Biswas <spyjetfayed@gmail.com>
> Acked-by: Lasse Collin <lasse.collin@tukaani.org>
> ---

I'm not quite sure what you changed in v2 compared to v1.
Usually, you should describe the changes below the --- line [1].

[1]: https://www.kernel.org/doc/html/v6.17/process/submitting-patches.html#commentary

However, the change itself LGTM, so FWIW:

Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>

Lasse,
Since this change is located under lib/, I assume it will be routed
through Andrew's tree?
If that's the case, then perhaps we should also Cc Andrew.

Regards,
Kuan-Wei

  reply	other threads:[~2025-10-13 20:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13 17:31 [PATCH v2] lib/xz: remove dead IA-64 (Itanium) support code Ankan Biswas
2025-10-13 20:25 ` Kuan-Wei Chiu [this message]
2025-10-13 20:44   ` Lasse Collin
2025-10-14  4:55     ` Ankan Biswas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aO1gOckA14Ed/26F@visitorckw-System-Product-Name \
    --to=visitorckw@gmail.com \
    --cc=david.hunter.linux@gmail.com \
    --cc=khalid@kernel.org \
    --cc=lasse.collin@tukaani.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=spyjetfayed@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox