From: Simon Horman <horms@kernel.org>
To: I Viswanath <viswanathiyyappan@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, sdf@fomichev.me, kuniyu@google.com,
ahmed.zaki@intel.com, aleksander.lobakin@intel.com,
jacob.e.keller@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linux.dev,
david.hunter.linux@gmail.com, khalid@kernel.org
Subject: Re: [RFC PATCH net-next v2 2/2] net: ethernet: Implement ndo_write_rx_config callback for the 8139cp driver
Date: Tue, 28 Oct 2025 15:17:41 +0000 [thread overview]
Message-ID: <aQDelXtB1--OdERb@horms.kernel.org> (raw)
In-Reply-To: <20251026175445.1519537-3-viswanathiyyappan@gmail.com>
On Sun, Oct 26, 2025 at 11:24:45PM +0530, I Viswanath wrote:
> Implement ndo_write_rx_config for the 8139cp driver
>
> Signed-off-by: I Viswanath <viswanathiyyappan@gmail.com>
...
> @@ -882,55 +886,53 @@ static netdev_tx_t cp_start_xmit (struct sk_buff *skb,
> goto out_unlock;
> }
>
> +static void cp_write_rx_config(struct net_device *dev)
> +{
> + struct cp_private *cp = netdev_priv(dev);
> + struct cp_rx_config snapshot;
> +
> + read_snapshot((&snapshot), struct cp_private);
> +
> + /* We can safely update without stopping the chip. */
> + cpw32_f(RxConfig, snapshot.rx_mode);
> +
> + cpw32_f(MAR0 + 0, snapshot.mc_filter[0]);
> + cpw32_f(MAR0 + 4, snapshot.mc_filter[1]);
> +}Firstly, think whether you have a bug fix or new "next-like" content.
> Then once decided, assuming that you use git, use the prefix flag, i.e.
FWIIW, this patch is mangled, e.g. the lines above.
> +
> /* Set or clear the multicast filter for this adaptor.
> This routine is not state sensitive and need not be SMP locked. */
...
prev parent reply other threads:[~2025-10-28 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-26 17:54 [RFC PATCH net-next v2 0/2] net: Split ndo_set_rx_mode into snapshot and deferred write I Viswanath
2025-10-26 17:54 ` [RFC PATCH net-next v2 1/2] net: Add ndo_write_rx_config and helper structs and functions: I Viswanath
2025-10-26 17:54 ` [RFC PATCH net-next v2 2/2] net: ethernet: Implement ndo_write_rx_config callback for the 8139cp driver I Viswanath
2025-10-28 15:17 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQDelXtB1--OdERb@horms.kernel.org \
--to=horms@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=david.hunter.linux@gmail.com \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=khalid@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=skhan@linuxfoundation.org \
--cc=viswanathiyyappan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox