From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0522327C02 for ; Tue, 16 Dec 2025 10:15:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765880128; cv=none; b=uAihr2wb5/5sNHoxPXmnUii4lDcXGgAB5F8IWtsMDMwnQ3ByxxqsOJ2Axy+KdIqVd7rrYHoHKQ7cYeY6NGWPocjXE/EMlzg4rxn+FBhdk7gJ1wyZc6bj+A7BRDLOTSeUsdiZ/VxF4N96QlUwBqLgjOtRifX/ixgwJT6obKO+koQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765880128; c=relaxed/simple; bh=cA2hUBGWGe7TtiYJoouOp5tOunrd6L/AfwtK5Ym9Ceg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aCYcXn7TGx2DYWqBhnj4Wk9AT0s7iz0fVP6t6ZOZS/khjrlHc5g38Eq9XpJ8LpRfUWh5gGm8GYfNWG4n3dou2snVUJuU6LcvGSKSD/R3niOOV6tdJptADAnztWes9pQbPenAm+F1vMmq40OYqTMYvunnjm+bTx5xFUMbMkizHDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aYlZjjdd; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aYlZjjdd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765880125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h471FGNIc2IuNt6ZxKT5WLDjfkpWMH0oarvYV9MqPK4=; b=aYlZjjddOYq3UP36B5SQBJfKDY0Nyn/D9onnNifU2lnrivklwEX/AhalE+KBWK50RrdV8S U7cSrs3205p8brzfHA173Kk9tfkK9qJuz53L65CigFpwThBfSgJy0mtKAtkNNzaybvu5N0 pxHGhIvz5vGj2hFHegJv37CNz1siYug= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-428-Ell0bgi6PZeWBVsbc6N4Ng-1; Tue, 16 Dec 2025 05:15:22 -0500 X-MC-Unique: Ell0bgi6PZeWBVsbc6N4Ng-1 X-Mimecast-MFC-AGG-ID: Ell0bgi6PZeWBVsbc6N4Ng_1765880120 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8FC9F18002C9; Tue, 16 Dec 2025 10:15:20 +0000 (UTC) Received: from fedora (unknown [10.72.116.190]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 397511956056; Tue, 16 Dec 2025 10:15:15 +0000 (UTC) Date: Tue, 16 Dec 2025 18:15:11 +0800 From: Ming Lei To: Clint George Cc: skhan@linuxfoundation.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com, linux-kernel-mentees@lists.linux.dev, khalid@kernel.org Subject: Re: [PATCH] kselftest/kublk: include message in _Static_assert for C11 compatibility Message-ID: References: <20251215085022.7642-1-clintbgeorge@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel-mentees@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251215085022.7642-1-clintbgeorge@gmail.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On Mon, Dec 15, 2025 at 02:20:22PM +0530, Clint George wrote: > Add descriptive message in the _Static_assert to comply with the C11 > standard requirement to prevent compiler from throwing out error. The > compiler throws an error when _Static_assert is used without a message as > that is a C23 extension. > > Signed-off-by: Clint George > --- > > [] Testing: > The diff between before and after of running the kselftest test of the > module shows no regression on system with x86 architecture Reviewed-by: Ming Lei Thanks, Ming