From: David Lechner <dlechner@baylibre.com>
To: Shrikant Raskar <raskar.shree97@gmail.com>,
jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Cc: nuno.sa@analog.com, andy@kernel.org, matt@ranostay.sg,
skhan@linuxfoundation.org, david.hunter.linux@gmail.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH v2 2/2] iio: health: max30100: Add pulse-width configuration via DT
Date: Fri, 10 Oct 2025 12:55:36 -0500 [thread overview]
Message-ID: <abc4209b-eebb-40c4-902c-b584028bb611@baylibre.com> (raw)
In-Reply-To: <20251008031737.7321-3-raskar.shree97@gmail.com>
On 10/7/25 10:17 PM, Shrikant Raskar wrote:
...
> --- a/drivers/iio/health/max30100.c
> +++ b/drivers/iio/health/max30100.c
> @@ -5,7 +5,6 @@
> * Copyright (C) 2015, 2018
> * Author: Matt Ranostay <matt.ranostay@konsulko.com>
> *
> - * TODO: enable pulse length controls via device tree properties
> */
>
> #include <linux/module.h>
> @@ -54,6 +53,10 @@
> #define MAX30100_REG_SPO2_CONFIG 0x07
> #define MAX30100_REG_SPO2_CONFIG_100HZ BIT(2)
> #define MAX30100_REG_SPO2_CONFIG_HI_RES_EN BIT(6)
> +#define MAX30100_REG_SPO2_CONFIG_PW_MASK GENMASK(1, 0)> +#define MAX30100_REG_SPO2_CONFIG_200US 0x0
> +#define MAX30100_REG_SPO2_CONFIG_400US 0x1
> +#define MAX30100_REG_SPO2_CONFIG_800US 0x2
> #define MAX30100_REG_SPO2_CONFIG_1600US 0x3
Would make more sense to put this new code before BIT(2) to preserve the
order of lowest to highest bits.
prev parent reply other threads:[~2025-10-10 17:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 3:17 [PATCH v2 0/2] iio: health: max30100: Add DT pulse-width support Shrikant Raskar
2025-10-08 3:17 ` [PATCH v2 1/2] dt-bindings: iio: max30100: Add pulse-width property Shrikant Raskar
2025-10-08 12:55 ` Rob Herring (Arm)
2025-10-11 10:38 ` Shrikant
2025-10-09 0:44 ` Krzysztof Kozlowski
2025-10-11 10:52 ` Shrikant
2025-10-10 17:49 ` David Lechner
2025-10-12 17:41 ` Shrikant
2025-10-12 17:06 ` Jonathan Cameron
2025-10-12 17:37 ` Shrikant
2025-10-08 3:17 ` [PATCH v2 2/2] iio: health: max30100: Add pulse-width configuration via DT Shrikant Raskar
2025-10-09 10:52 ` Nuno Sá
2025-10-12 17:45 ` Shrikant
2025-10-10 16:24 ` kernel test robot
2025-10-10 17:55 ` David Lechner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abc4209b-eebb-40c4-902c-b584028bb611@baylibre.com \
--to=dlechner@baylibre.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david.hunter.linux@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@ranostay.sg \
--cc=nuno.sa@analog.com \
--cc=raskar.shree97@gmail.com \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox