From: Ankan Biswas <spyjetfayed@gmail.com>
To: Lasse Collin <lasse.collin@tukaani.org>,
Kuan-Wei Chiu <visitorckw@gmail.com>
Cc: skhan@linuxfoundation.org, khalid@kernel.org,
david.hunter.linux@gmail.com, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH v2] lib/xz: remove dead IA-64 (Itanium) support code
Date: Tue, 14 Oct 2025 10:25:31 +0530 [thread overview]
Message-ID: <ad39c405-bf7a-422b-9f33-248ba9d6b824@gmail.com> (raw)
In-Reply-To: <20251013234407.11e70f22.lasse.collin@tukaani.org>
On 10/14/25 2:14 AM, Lasse Collin wrote:
> On 2025-10-14 Kuan-Wei Chiu wrote:
>> On Mon, Oct 13, 2025 at 11:01:58PM +0530, Ankan Biswas wrote:
>>> Note that the upstream version of xz_dec_bcj.c still retains support
>>> for the IA-64 BCJ filter.
>>
>> Not sure if it's necessary to mention this, but I guess it's fine.
>
> Information about upstream version isn't needed in Linux commit log, so
> that sentence could be omitted.
>
It felt like a good idea to put this info, but since it is not directly
related to the kernel I would remove it for v3.
>> I'm not quite sure what you changed in v2 compared to v1.
>
> It added the second hunk to the diff of xz_private.h.
>
>> Lasse,
>> Since this change is located under lib/, I assume it will be routed
>> through Andrew's tree?
>> If that's the case, then perhaps we should also Cc Andrew.
>
> Yes, putting him into the To field and others as Cc should make the
> patch go forward. Sorry that I didn't notice and comment this myself
> earlier.
>
I will add Andrew Morton for v3 in To, and the rest in Cc and add the
changelog part.
Hi Kuan-Wei and Lasse,
Thank you for your feedback, it was very helpful.
Regards,
Ankan Biswas
prev parent reply other threads:[~2025-10-14 4:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 17:31 [PATCH v2] lib/xz: remove dead IA-64 (Itanium) support code Ankan Biswas
2025-10-13 20:25 ` Kuan-Wei Chiu
2025-10-13 20:44 ` Lasse Collin
2025-10-14 4:55 ` Ankan Biswas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad39c405-bf7a-422b-9f33-248ba9d6b824@gmail.com \
--to=spyjetfayed@gmail.com \
--cc=david.hunter.linux@gmail.com \
--cc=khalid@kernel.org \
--cc=lasse.collin@tukaani.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox