From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Vidhu Sarwal <vidhu.linux@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Shuah Khan" <skhan@linuxfoundation.org>,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH] iio: light: al3010: fix incorrect scale for the highest gain range
Date: Thu, 2 Jul 2026 12:44:54 +0300 [thread overview]
Message-ID: <akYzFtxKhq5U2kFY@ashevche-desk.local> (raw)
In-Reply-To: <20260702052913.114130-1-vidhu.linux@gmail.com>
On Thu, Jul 02, 2026 at 10:59:13AM +0530, Vidhu Sarwal wrote:
> al3010_scales[] encodes the highest gain range as {0, 1187200}.
> For IIO_VAL_INT_PLUS_MICRO, the fractional part must be less than
> 1000000, so the scale 1.1872 should instead be represented as
> {1, 187200}.
>
> Since write_raw() compares the value from userspace against this
> table, writing 1.1872 scale never matches the malformed
> entry and returns -EINVAL. As a result, the highest gain range cannot
> be selected. Reading the scale in that state also reports the malformed
> value.
Trailing spaces in the last line of the above paragraph.
>
> Fixes: c36b5195ab70 ("iio: light: add Dyna-Image AL3010 driver")
> Signed-off-by: Vidhu Sarwal <vidhu.linux@gmail.com>
...
> static const int al3010_scales[][2] = {
> - {0, 1187200}, {0, 296800}, {0, 74200}, {0, 18600}
> + {1, 187200}, {0, 296800}, {0, 74200}, {0, 18600}
While at it, add a trailing comma.
> };
Otherwise LGTM, thanks.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-02 9:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 5:29 [PATCH] iio: light: al3010: fix incorrect scale for the highest gain range Vidhu Sarwal
2026-07-02 9:44 ` Andy Shevchenko [this message]
2026-07-02 17:33 ` Jonathan Cameron
2026-07-04 11:52 ` [PATCH v2] " Vidhu Sarwal
2026-07-04 12:13 ` Andy Shevchenko
2026-07-04 23:06 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akYzFtxKhq5U2kFY@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=skhan@linuxfoundation.org \
--cc=vidhu.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).