From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCA43C10DCE for ; Wed, 18 Mar 2020 18:37:55 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9984720780 for ; Wed, 18 Mar 2020 18:37:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9984720780 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 6645986DCF; Wed, 18 Mar 2020 18:37:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yH-gfoNRd8jy; Wed, 18 Mar 2020 18:37:54 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id C887B86519; Wed, 18 Mar 2020 18:37:54 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B4992C18DA; Wed, 18 Mar 2020 18:37:54 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 747A8C013E for ; Wed, 18 Mar 2020 18:37:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 638FF26427 for ; Wed, 18 Mar 2020 18:37:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0RkF1yeNcGop for ; Wed, 18 Mar 2020 18:37:52 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by silver.osuosl.org (Postfix) with ESMTPS id 1A9E625DB6 for ; Wed, 18 Mar 2020 18:37:51 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.70,568,1574118000"; d="scan'208";a="441036199" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Mar 2020 19:37:42 +0100 Date: Wed, 18 Mar 2020 19:37:42 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Jaskaran Singh In-Reply-To: <20200316100319.27935-11-jaskaransingh7654321@gmail.com> Message-ID: References: <20200316100319.27935-1-jaskaransingh7654321@gmail.com> <20200316100319.27935-11-jaskaransingh7654321@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr Subject: Re: [Linux-kernel-mentees] [PATCH 10/26] parsing_cocci: single_statement: Add cases for ParenType/FunctionType X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Mon, 16 Mar 2020, Jaskaran Singh wrote: > ParenType/FunctionType are now types in the SmPL ASTs. Add > cases for these types in single_statement.ml. > > Signed-off-by: Jaskaran Singh > --- > parsing_cocci/single_statement.ml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/parsing_cocci/single_statement.ml b/parsing_cocci/single_statement.ml > index 46408b73..48d77b5a 100644 > --- a/parsing_cocci/single_statement.ml > +++ b/parsing_cocci/single_statement.ml > @@ -166,6 +166,8 @@ and left_typeC t = > | Ast0.Signed(sgn,ty) -> modif_before_mcode sgn > | Ast0.Pointer(ty,star) -> left_typeC ty > | Ast0.FunctionPointer(ty,lp1,star,rp1,lp2,params,rp2) -> left_typeC ty > + | Ast0.ParenType(lp,ty,rp) -> left_typeC ty This doesn't look correct. ty is not the leftmost thing. julia > + | Ast0.FunctionType(ty,lp,params,rp) -> left_typeC ty > | Ast0.Array(ty,lb,size,rb) -> left_typeC ty > | Ast0.Decimal(dec,lp,length,comma,precision_opt,rp) -> > modif_before_mcode dec > -- > 2.21.1 > > _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees