Hello, Just a few nitpicks. These might not justify a v3, as Jonathan sometimes fixes up such thing while applying. On Sun, Aug 02, 2026 at 10:51:31AM +0800, Adi Nata wrote: > Change instance of __attribute__((__packed__)) to __packed per checkpatch.pl warning > > Reported by checkpatch: > FILE: drivers/iio/chemical/sgp30.c > WARNING: Prefer __packed over __attribute__((__packed__)) > +} __attribute__((__packed__)); > > Signed-off-by: Adi Nata > > Reviewed-by: Joshua Crofts No empty lines in the S-o-B block, and please put your S-o-b last. > v2: > - Rename commit title and message the v2 changelog belongs after the tripple dash. > > --- > drivers/iio/chemical/sgp30.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/chemical/sgp30.c b/drivers/iio/chemical/sgp30.c > index f10bbebc29e4..c33592a1e0c9 100644 > --- a/drivers/iio/chemical/sgp30.c > +++ b/drivers/iio/chemical/sgp30.c > @@ -82,7 +82,7 @@ struct sgp_version { > struct sgp_crc_word { > __be16 value; > u8 crc8; > -} __attribute__((__packed__)); > +} __packed; Otherwise looks fine. Acked-by: Uwe Kleine-König Best regards Uwe