public inbox for linux-kernel-mentees@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: "David Gow" <davidgow@google.com>,
	"Bruno Sobreira França" <brunofrancadevsec@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	rmoar@google.com, kunit-dev@googlegroups.com,
	linux-kernel-mentees@lists.linuxfoundation.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3] lib/math: Add int_log test suite
Date: Thu, 3 Oct 2024 15:39:10 -0600	[thread overview]
Message-ID: <bb534e04-618d-48b9-ae19-00301e7c73b4@linuxfoundation.org> (raw)
In-Reply-To: <CABVgOSmEHtSHHsreVq38AzD+PnacgY6h-+Cv1u4n4U-1yjqwUw@mail.gmail.com>

On 10/3/24 01:00, David Gow wrote:
> On Wed, 25 Sept 2024 at 10:56, Bruno Sobreira França
> <brunofrancadevsec@gmail.com> wrote:
>>
>> This commit introduces KUnit tests for the intlog2 and intlog10
>> functions, which compute logarithms in base 2 and base 10, respectively.
>> The tests cover a range of inputs to ensure the correctness of these
>> functions across common and edge cases.
>>
>> Signed-off-by: Bruno Sobreira França <brunofrancadevsec@gmail.com>
>> ---
> 
> Thanks, this looks good to me.
> 
> Reviewed-by: David Gow <davidgow@google.com>
> 
> Cheers,
> -- David
> 
>> Changes in v3:
>>    - Fix checkpatch issues reintroduced in v2
>> Changes in v2:
>>    - Fix the overflow warning reported by the kernel test robot
>> ---

Bruno,

This doesn't apply - please rebase on top of linux-kselftest kunit branch
and send me v4.

I tried to apply, but a few too many merge conflicts. Rebase is a safer
option.

thanks,
-- Shuah


      reply	other threads:[~2024-10-03 21:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-25  2:56 [PATCH v3] lib/math: Add int_log test suite Bruno Sobreira França
2024-10-03  7:00 ` David Gow
2024-10-03 21:39   ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb534e04-618d-48b9-ae19-00301e7c73b4@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=brunofrancadevsec@gmail.com \
    --cc=davidgow@google.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmoar@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox