From: Shuah Khan <skhan@linuxfoundation.org>
To: Brigham Campbell <me@brighamcampbell.com>,
linux-kernel-mentees@lists.linux.dev,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Shuah Khan <shuah@kernel.org>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] kselftest: x86: Improve MOV SS test result message
Date: Fri, 23 May 2025 12:46:24 -0600 [thread overview]
Message-ID: <bd22525a-dd4c-47b0-8cd0-52c0e8c64ca6@linuxfoundation.org> (raw)
In-Reply-To: <20250523073220.112238-2-me@brighamcampbell.com>
On 5/23/25 01:32, Brigham Campbell wrote:
> Apparently, this test completes successfully when it completes execution
> without either causing a kernel panic or being killed by the kernel.
> This new test result message is more descriptive and grammatically
> correct.
>
The change log description usually is in imperative - e.g:
"Change test result message to be more descriptive and grammatically
correct.."
> There are no changes in v2. I'm resending this patch because I addressed
> it to the wrong email for Shuah.
Version change information goes under the --- after the Signed-off-by
>
> Signed-off-by: Brigham Campbell <me@brighamcampbell.com>
> ---
> tools/testing/selftests/x86/mov_ss_trap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/x86/mov_ss_trap.c b/tools/testing/selftests/x86/mov_ss_trap.c
> index f22cb6b382f9..d80033c0d7eb 100644
> --- a/tools/testing/selftests/x86/mov_ss_trap.c
> +++ b/tools/testing/selftests/x86/mov_ss_trap.c
> @@ -269,6 +269,6 @@ int main()
> );
> }
>
> - printf("[OK]\tI aten't dead\n");
> + printf("[OK]\tkernel handled MOV SS without crashing test\n");
> return 0;
> }
thanks,
-- Shuah
prev parent reply other threads:[~2025-05-23 18:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 7:32 [PATCH v2] kselftest: x86: Improve MOV SS test result message Brigham Campbell
2025-05-23 18:46 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd22525a-dd4c-47b0-8cd0-52c0e8c64ca6@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=me@brighamcampbell.com \
--cc=mingo@redhat.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox