Re: [PATCH v3] Documentation: cve Korean translation

Jonathan Corbet
2024-05-27T14:55:37Z

Yunseong Kim <yskelg@gmail.com> writes:

> On 5/27/24 10:50 오후, Jonathan Corbet wrote:
>> Yunseong Kim <yskelg@gmail.com> writes:
>>
>>>> 1) Why do I have three versions of it in my mailbox, sent over a period
>>>> of 13 minutes? What changed between the versions?
>>>
>>> Sorry, I forgot the name of the reviewer when I first sent the
>>> documentation content related patch version 2.
>>
>> Which is fine, but...
>>
>>>> Normally, you want to wait for reviews to come in on one version
>>>> before posting the next, and you should put a comment after the "---"
>>>> line saying what changed.
>>>>
>>>> 2) When did this review from Jinwoo Park happen? I was not copied on
>>>> that.
>>
>> You did not answer this question. Reviews should generally be done in
>> public, but that does not seem to have happened here?
>
> Oops, sorry about that, Jonathan.
>
> Jinwoo Park sent me the review below, and I've updated some of ambiguous
> words in patch version 2.
>
> https://lore.kernel.org/linux-doc/57f0d90c-4cc6-4418-ab79-6ae026d8ae09@gmail.com/T/#t

It does look like the patch was reviewed, but no Reviewed-by tag was
offered. *Never* apply a Reviewed-by tag that has not been explicitly
given to you.

Jinwoo, would you like to offer that tag for this patch?

Thanks,

jon